From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8715A0613 for ; Mon, 23 Sep 2019 17:00:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0210B1BF04; Mon, 23 Sep 2019 17:00:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9B5161BEFD for ; Mon, 23 Sep 2019 17:00:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 08:00:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,540,1559545200"; d="scan'208";a="200561583" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 23 Sep 2019 08:00:50 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 08:00:50 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 08:00:50 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.113]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 23:00:48 +0800 From: "Wang, Haiyue" To: "Ye, Xiaolong" , "Rong, Leyi" CC: "Lu, Wenzhuo" , "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue Thread-Index: AQHVbrOKL1X0666/nEe3Biswc1cT3ac40a4AgACP4KA= Date: Mon, 23 Sep 2019 15:00:48 +0000 Message-ID: References: <20190829023421.112551-1-leyi.rong@intel.com> <20190919062553.79257-1-leyi.rong@intel.com> <20190919062553.79257-4-leyi.rong@intel.com> <20190923142424.GB15446@intel.com> In-Reply-To: <20190923142424.GB15446@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDE0ODVlODEtMmJiOS00MjExLWE1NjYtNjAwYWRkZmZiM2IyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK2t5bWtDdzZvRThZUllhYXJyOEFNYUZLS1FSMEo3QUx2TkxqaU9YOWRkdE1xdzRtOFRqazlNR2FhQ3ZPSTN4bCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, September 23, 2019 22:24 > To: Rong, Leyi > Cc: Wang, Haiyue ; Lu, Wenzhuo ; Zhang, Qi Z > ; dev@dpdk.org > Subject: Re: [PATCH v4 3/6] net/ice: add protocol extraction support for = per Rx queue >=20 > On 09/19, Leyi Rong wrote: > >From: Haiyue Wang > > >=20 > [snip] >=20 > >+static inline uint8_t > >+ice_rxdid_to_proto_xtr_type(uint8_t rxdid) > >+{ > >+ static uint8_t xtr_map[] =3D { > >+ [ICE_RXDID_COMMS_AUX_VLAN] =3D PROTO_XTR_VLAN, > >+ [ICE_RXDID_COMMS_AUX_IPV4] =3D PROTO_XTR_IPV4, > >+ [ICE_RXDID_COMMS_AUX_IPV6] =3D PROTO_XTR_IPV6, > >+ [ICE_RXDID_COMMS_AUX_IPV6_FLOW] =3D PROTO_XTR_IPV6_FLOW, > >+ [ICE_RXDID_COMMS_AUX_TCP] =3D PROTO_XTR_TCP, > >+ }; > >+ > >+ return rxdid < RTE_DIM(xtr_map) ? xtr_map[rxdid] : PROTO_XTR_NONE; > >+} > >+ > >+static inline uint8_t > >+ice_proto_xtr_type_to_rxdid(uint8_t xtr_tpye) >=20 > s/xtr_tpye/xtr_type/ >=20 Got it! > >+{ > >+ static uint8_t rxdid_map[] =3D { Add this line: [PROTO_XTR_NONE] =3D ICE_RXDID_COMMS_GENERIC, > >+ [PROTO_XTR_VLAN] =3D ICE_RXDID_COMMS_AUX_VLAN, > >+ [PROTO_XTR_IPV4] =3D ICE_RXDID_COMMS_AUX_IPV4, > >+ [PROTO_XTR_IPV6] =3D ICE_RXDID_COMMS_AUX_IPV6, > >+ [PROTO_XTR_IPV6_FLOW] =3D ICE_RXDID_COMMS_AUX_IPV6_FLOW, > >+ [PROTO_XTR_TCP] =3D ICE_RXDID_COMMS_AUX_TCP, > >+ }; > >+ uint8_t rxdid; > >+ > >+ rxdid =3D xtr_tpye < RTE_DIM(rxdid_map) ? rxdid_map[xtr_tpye] : 0; > >+ > >+ return rxdid !=3D 0 ? rxdid : ICE_RXDID_COMMS_GENERIC; >=20 > Maybe just >=20 > return xtr_type < RTE_DIM(rxdid_map) ? > rxdid_map[xtr_type] : ICE_RXDID_COMMS_GENERIC; >=20 Then this, will be updated in next version. > as previous ice_rxdid_to_proto_xtr_type. >=20 >=20 > Thanks, > Xiaolong