From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A1A2A0613 for ; Thu, 26 Sep 2019 15:49:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C49885B32; Thu, 26 Sep 2019 15:49:01 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 96E6E31FC for ; Thu, 26 Sep 2019 15:48:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 06:48:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,552,1559545200"; d="scan'208";a="389615258" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 26 Sep 2019 06:48:58 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 06:48:58 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 06:48:58 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.113]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 21:48:56 +0800 From: "Wang, Haiyue" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Kinsella, Ray" , "Iremonger, Bernard" , "Sun, Chenmin" Thread-Topic: [PATCH v1 1/4] ethdev: add the API for getting burst mode information Thread-Index: AQHVdGEaS0eKZ8EU+UOVSdpnZKLRvac9cUcAgACHNVA= Date: Thu, 26 Sep 2019 13:48:55 +0000 Message-ID: References: <20190926114818.91063-1-haiyue.wang@intel.com> <20190926114818.91063-2-haiyue.wang@intel.com> <20190926134118.GA91335@intel.com> In-Reply-To: <20190926134118.GA91335@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDA5ZTQwNTUtMDA1MC00MWM3LTlkNzctZWUzMjhlZWFmMmI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicDBncmd3ZjBDbkRzOGpFbUZnWW1JeGs0Y2F4MzZIVE5VVEh4Y0xScEozZUwrKzRsNnE1VTBFcFByaVVvdnBFWSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/4] ethdev: add the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, September 26, 2019 21:41 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yigit, Ferruh ; Kinsella, Ray <= ray.kinsella@intel.com>; > Iremonger, Bernard ; Sun, Chenmin > Subject: Re: [PATCH v1 1/4] ethdev: add the API for getting burst mode in= formation >=20 > On 09/26, Haiyue Wang wrote: > >Some PMDs have more than one RX/TX burst paths, add the ethdev API > >that allows an application to retrieve the mode information about > >Rx/Tx packet burst such as Scalar or Vector, and Vector technology > >like AVX2. > > > >Signed-off-by: Haiyue Wang > >Acked-by: Bernard Iremonger > >--- > > doc/guides/rel_notes/release_19_11.rst | 9 +++ > > lib/librte_ethdev/rte_ethdev.c | 75 ++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev_core.h | 5 ++ > > lib/librte_ethdev/rte_ethdev_version.map | 5 ++ > > 5 files changed, 176 insertions(+) > > >=20 > [snip] >=20 > >+typedef void (*eth_burst_mode_get_t)(struct rte_eth_dev *dev, > >+ uint16_t queue_id, struct rte_eth_burst_mode *mode); > >+ >=20 > There is ongoing effort to change the return type of dev_ops callback fro= m > void to int, like [1] >=20 > Better to keep align with it. >=20 > [1] http://patchwork.dpdk.org/project/dpdk/list/?series=3D6391 >=20 OK, will update on v2. > Thanks, > Xiaolong >=20 > > typedef int (*mtu_set_t)(struct rte_eth_dev *dev, uint16_t mtu); > > /**< @internal Set MTU. */ > > > >@@ -542,6 +545,8 @@ struct eth_dev_ops { > > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > > eth_rxq_info_get_t rxq_info_get; /**< retrieve RX queue inform= ation. */ > > eth_txq_info_get_t txq_info_get; /**< retrieve TX queue inform= ation. */ > >+ eth_burst_mode_get_t rx_burst_mode_get; /**< Get RX burst mode *= / > >+ eth_burst_mode_get_t tx_burst_mode_get; /**< Get TX burst mode *= / > > eth_fw_version_get_t fw_version_get; /**< Get firmware version. = */ > > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > > /**< Get packet types supported and identified by device. */ > >diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethde= v/rte_ethdev_version.map > >index 6df42a47b..e59d51648 100644 > >--- a/lib/librte_ethdev/rte_ethdev_version.map > >+++ b/lib/librte_ethdev/rte_ethdev_version.map > >@@ -283,4 +283,9 @@ EXPERIMENTAL { > > > > # added in 19.08 > > rte_eth_read_clock; > >+ > >+ # added in 19.11 > >+ rte_eth_rx_burst_mode_get; > >+ rte_eth_tx_burst_mode_get; > >+ rte_eth_burst_mode_option_name; > > }; > >-- > >2.17.1 > >