From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2665A0613 for ; Thu, 26 Sep 2019 18:36:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14EB42BE1; Thu, 26 Sep 2019 18:36:15 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D4F232BD8 for ; Thu, 26 Sep 2019 18:36:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 09:36:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,552,1559545200"; d="scan'208";a="191889543" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 26 Sep 2019 09:36:13 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 09:36:12 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 09:36:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.113]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Fri, 27 Sep 2019 00:36:10 +0800 From: "Wang, Haiyue" To: Stephen Hemminger CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Ye, Xiaolong" , "Kinsella, Ray" , "Iremonger, Bernard" , "Sun, Chenmin" Thread-Topic: [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode information Thread-Index: AQHVdGEZMsbMkx3vqEaJ++h0IOIPgqc9l1IAgACPF0A= Date: Thu, 26 Sep 2019 16:36:09 +0000 Message-ID: References: <20190926114818.91063-1-haiyue.wang@intel.com> <20190926085728.51161998@hermes.lan> In-Reply-To: <20190926085728.51161998@hermes.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTI0NzJiZTQtMDY2NC00NTk5LWFmMzUtZGI4Y2YyYWQwYmEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib2JpeCtaWGRhSXBBYVViZkh6YmNLanh4UlwvRXRRWmJ6b2VKQTU2bDE2QWtqaXF3SUlseFlORWJlWjVcL2hYTmJZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, September 26, 2019 23:57 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yigit, Ferruh ; Ye, Xiaolong ; > Kinsella, Ray ; Iremonger, Bernard ; Sun, Chenmin > > Subject: Re: [dpdk-dev] [PATCH v1 0/4] get Rx/Tx packet burst mode inform= ation >=20 > On Thu, 26 Sep 2019 19:48:14 +0800 > Haiyue Wang wrote: >=20 > > RFCv3 -> v1: > > https://patchwork.dpdk.org/patch/59103/ > > https://patchwork.dpdk.org/patch/59104/ > > https://patchwork.dpdk.org/patch/59105/ > > https://patchwork.dpdk.org/patch/59106/ > > 1). Use the function 'rte_bsf64' to iterate the options for > > getting the name. > > > > Haiyue Wang (4): > > ethdev: add the API for getting burst mode information > > net/i40e: support to get the Rx/Tx burst mode > > net/ice: support to get the Rx/Tx burst mode > > app/testpmd: show the Rx/Tx burst mode description > > > > app/test-pmd/config.c | 29 +++++++++ > > doc/guides/rel_notes/release_19_11.rst | 9 +++ > > drivers/net/i40e/i40e_ethdev.c | 2 + > > drivers/net/i40e/i40e_ethdev.h | 4 ++ > > drivers/net/i40e/i40e_rxtx.c | 72 +++++++++++++++++++++ > > drivers/net/ice/ice_ethdev.c | 2 + > > drivers/net/ice/ice_rxtx.c | 54 ++++++++++++++++ > > drivers/net/ice/ice_rxtx.h | 4 ++ > > lib/librte_ethdev/rte_ethdev.c | 75 ++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 82 ++++++++++++++++++++++++ > > lib/librte_ethdev/rte_ethdev_core.h | 5 ++ > > lib/librte_ethdev/rte_ethdev_version.map | 5 ++ > > 12 files changed, 343 insertions(+) > > >=20 > A couple of meta comments: > 1) Could this be part of dev_info_get somehow? >=20 https://patchwork.dpdk.org/patch/57624/ 'Think of a better way that doesn't break ABI.' ;-) > 2) Why should application care? Is this just a test hook? https://patches.dpdk.org/cover/57623/ This is from FD.io VPP's bug, and finally, we come out this API for application accessing the burst mode information. It can be used as a simple trace or something like performance analysis like why slow ? Not in vector, anyway, application can get this burst mode information now, not just open PMD debug log level.