From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A27C6A328D for ; Wed, 23 Oct 2019 05:16:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F8F11BF2D; Wed, 23 Oct 2019 05:16:21 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3A5BF1BF15 for ; Wed, 23 Oct 2019 05:16:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 20:16:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,219,1569308400"; d="scan'208";a="397905589" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 22 Oct 2019 20:16:17 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 22 Oct 2019 20:16:17 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 22 Oct 2019 20:16:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.176]) by SHSMSX152.ccr.corp.intel.com ([10.239.6.52]) with mapi id 14.03.0439.000; Wed, 23 Oct 2019 11:16:14 +0800 From: "Wang, Haiyue" To: "Ananyev, Konstantin" , Olivier Matz , "dev@dpdk.org" CC: Andrew Rybchenko , "Richardson, Bruce" , Jerin Jacob Kollanukkaran , "Wiles, Keith" , =?iso-8859-1?Q?Morten_Br=F8rup?= , Stephen Hemminger , Thomas Monjalon Thread-Topic: [PATCH v2] mbuf: support dynamic fields and flags Thread-Index: AQHVhPkmy3Bf3WM2d0mLozWwBzvtDqdmxoeAgADPNLA= Date: Wed, 23 Oct 2019 03:16:13 +0000 Message-ID: References: <20190710092907.5565-1-olivier.matz@6wind.com> <20191017144219.32708-1-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725801A8C6E2BD@IRSMSX104.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801A8C6E2BD@IRSMSX104.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2I1Y2E3NjktMDY5OS00ZjZkLWI3NzAtY2M4OThmNjg5ZTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNzdQcHJ6WUR0M3lGODN1d0FcLzIzZ2R3NGxiWGtydVFYQkRWNFwvSDl6Sk82U2N4bk1qYjlMb2tZNm9FcFhNRTdWIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, October 23, 2019 06:52 > To: Olivier Matz ; dev@dpdk.org > Cc: Andrew Rybchenko ; Richardson, Bruce ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran ; Wiles, Keith > ; Morten Br=F8rup ; Step= hen Hemminger > ; Thomas Monjalon > Subject: RE: [PATCH v2] mbuf: support dynamic fields and flags >=20 >=20 > > Many features require to store data inside the mbuf. As the room in mbu= f > > structure is limited, it is not possible to have a field for each > > feature. Also, changing fields in the mbuf structure can break the API > > or ABI. > > > > This commit addresses these issues, by enabling the dynamic registratio= n > > of fields or flags: > > > > - a dynamic field is a named area in the rte_mbuf structure, with a > > given size (>=3D 1 byte) and alignment constraint. > > - a dynamic flag is a named bit in the rte_mbuf structure. > > > > The typical use case is a PMD that registers space for an offload > > feature, when the application requests to enable this feature. As > > the space in mbuf is limited, the space should only be reserved if it > > is going to be used (i.e when the application explicitly asks for it). > > > > The registration can be done at any moment, but it is not possible > > to unregister fields or flags for now. > > > > Signed-off-by: Olivier Matz > > Acked-by: Thomas Monjalon > > --- > > > > v2 > > > > * Rebase on top of master: solve conflict with Stephen's patchset > > (packet copy) > > * Add new apis to register a dynamic field/flag at a specific place > > * Add a dump function (sugg by David) > > * Enhance field registration function to select the best offset, keepin= g > > large aligned zones as much as possible (sugg by Konstantin) > > * Use a size_t and unsigned int instead of int when relevant > > (sugg by Konstantin) > > * Use "uint64_t dynfield1[2]" in mbuf instead of 2 uint64_t fields > > (sugg by Konstantin) > > * Remove unused argument in private function (sugg by Konstantin) > > * Fix and simplify locking (sugg by Konstantin) > > * Fix minor typo > > > > rfc -> v1 > > > > * Rebase on top of master > > * Change registration API to use a structure instead of > > variables, getting rid of #defines (Stephen's comment) > > * Update flag registration to use a similar API as fields. > > * Change max name length from 32 to 64 (sugg. by Thomas) > > * Enhance API documentation (Haiyue's and Andrew's comments) > > * Add a debug log at registration > > * Add some words in release note > > * Did some performance tests (sugg. by Andrew): > > On my platform, reading a dynamic field takes ~3 cycles more > > than a static field, and ~2 cycles more for writing. > > > > app/test/test_mbuf.c | 145 ++++++- > > doc/guides/rel_notes/release_19_11.rst | 7 + > > lib/librte_mbuf/Makefile | 2 + > > lib/librte_mbuf/meson.build | 6 +- > > lib/librte_mbuf/rte_mbuf.h | 23 +- > > lib/librte_mbuf/rte_mbuf_dyn.c | 548 +++++++++++++++++++++++++ > > lib/librte_mbuf/rte_mbuf_dyn.h | 226 ++++++++++ > > lib/librte_mbuf/rte_mbuf_version.map | 7 + > > 8 files changed, 959 insertions(+), 5 deletions(-) > > create mode 100644 lib/librte_mbuf/rte_mbuf_dyn.c > > create mode 100644 lib/librte_mbuf/rte_mbuf_dyn.h > > > > diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c > > index b9c2b2500..01cafad59 100644 > > --- a/app/test/test_mbuf.c > > +++ b/app/test/test_mbuf.c > > @@ -28,6 +28,7 @@ > > #include > > #include > > #include > > +#include > > [snip] > > +int > > +rte_mbuf_dynflag_register_bitnum(const struct rte_mbuf_dynflag *params= , > > + unsigned int req) > > +{ > > + int ret; > > + > > + if (req !=3D UINT_MAX && req >=3D 64) { >=20 > Might be better to replace 64 with something like sizeof(mbuf->ol_flags) = * CHAR_BIT or so. Might introduce a new macro like kernel: /** * FIELD_SIZEOF - get the size of a struct's field * @t: the target struct * @f: the target struct's field * Return: the size of @f in the struct definition without having a * declared instance of @t. */ #define FIELD_SIZEOF(t, f) (sizeof(((t*)0)->f)) Then: FIELD_SIZEOF(rte_mbuf, ol_flags) * CHAR_BIT > Apart from that: > Acked-by: Konstantin Ananyev >=20 > > + rte_errno =3D EINVAL; > > + return -1; > > + } > > + > > + rte_mcfg_tailq_write_lock(); > > + ret =3D __rte_mbuf_dynflag_register_bitnum(params, req); > > + rte_mcfg_tailq_write_unlock(); > > + > > + return ret; > > +} > > +