From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Cc: DPDK <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"ophirmu@mellanox.com" <ophirmu@mellanox.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"olgas@mellanox.com" <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v4] net/tap: perform proto field update for tun only
Date: Wed, 23 May 2018 04:48:47 +0000 [thread overview]
Message-ID: <E412B4EF-ACAD-4D2C-96A7-66D73A33E215@intel.com> (raw)
In-Reply-To: <1527050693-162950-1-git-send-email-vipin.varghese@intel.com>
> On May 22, 2018, at 11:44 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>
> The TX function is shared between TAP and TUN PMD. Checking TUN-TAP
> type field will ensure the TAP PMD will always have protocol field
> as 0.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Changes in V4:
> - convert comparision with MACRO - Keith Wiles
> - add LOG err for tun using set MAC - Ophir Munk
>
> Changes in V3:
> - remove type field from rx struct - Ophir Munk
> - add space for comment in struct - Ophir Munk
> - pass type field into eth_dev_tap_create - Ophir Munk
> - replace with enum value for type - Ophir Munk
> - return as 'not supported' for mac_set - Vipin Varghese
>
> Changes in V2:
> - updated in comment wording - Keith Wiles
> - remove debug print from tx code - Keith Wiles
> —
Looks good to me.
Acked-by: Keith Wiles<keith.wiles@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2018-05-23 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 4:44 Vipin Varghese
2018-05-23 4:48 ` Wiles, Keith [this message]
2018-05-23 8:11 ` Ferruh Yigit
2018-05-23 8:26 ` Varghese, Vipin
-- strict thread matches above, loose matches on Subject: below --
2018-05-22 10:47 [dpdk-dev] [PATCH v3] " Vipin Varghese
2018-05-22 22:04 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-05-22 22:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E412B4EF-ACAD-4D2C-96A7-66D73A33E215@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=thomas@monjalon.net \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).