Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits

["Wiles, Keith" <keith.wiles@intel.com>]

> On Jan 23, 2019, at 5:03 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> 23/01/2019 11:15, Burakov, Anatoly:
>> On 22-Jan-19 4:27 PM, Ilya Maximets wrote:
>>> Modern memory mode allowes to not reserve any memory by the
>>> '--socket-mem' option. i.e. it could be possible to specify
>>> zero preallocated memory like '--socket-mem 0'.
>>> Also, it should be possible to configure unlimited memory
>>> allocations by '--socket-limit 0'.
>>> 
>>> Both cases are impossible now and blocks starting the DPDK
>>> application:
>>> 
>>>     ./dpdk-app --socket-limit 0 <...>
>>>     EAL: invalid parameters for --socket-limit
>>>     EAL: Invalid 'command line' arguments.
>>>     Unable to initialize DPDK: Invalid argument
>>> 
>>> Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
>>> Cc: stable@dpdk.org
>>> 
>>> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
>>> ---
>> 
>> That's kind of an odd parameter to pass, as it is assumed that if you 
>> don't need any limitations or preallocated memory, you don't specify 
>> these flags in the first place, but OK :)

I personally would have liked a comment replacing the three lines stating that total_mem of zero is fine as it only seems reasonable to document the reason total_mem can be zero.
>> 
>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Applied, thanks

Regards,
Keith