From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 748DEDE3; Thu, 24 Jan 2019 02:12:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jan 2019 17:12:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,514,1539673200"; d="scan'208";a="314299124" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 23 Jan 2019 17:12:07 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.160]) by FMSMSX103.amr.corp.intel.com ([169.254.2.205]) with mapi id 14.03.0415.000; Wed, 23 Jan 2019 17:12:07 -0800 From: "Wiles, Keith" To: Thomas Monjalon CC: Ilya Maximets , "stable@dpdk.org" , "Burakov, Anatoly" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits Thread-Index: AQHUs2d5dnDeTCer9UaGMexKlJ8306W+IvCA Date: Thu, 24 Jan 2019 01:12:06 +0000 Message-ID: References: <20190122162714.9144-1-i.maximets@samsung.com> <1a3eea71-1b1a-7589-48fa-71a23ee1e0a2@intel.com> <4900677.582JXVQWH1@xps> In-Reply-To: <4900677.582JXVQWH1@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.40.157] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2019 01:12:09 -0000 > On Jan 23, 2019, at 5:03 PM, Thomas Monjalon wrote: >=20 > 23/01/2019 11:15, Burakov, Anatoly: >> On 22-Jan-19 4:27 PM, Ilya Maximets wrote: >>> Modern memory mode allowes to not reserve any memory by the >>> '--socket-mem' option. i.e. it could be possible to specify >>> zero preallocated memory like '--socket-mem 0'. >>> Also, it should be possible to configure unlimited memory >>> allocations by '--socket-limit 0'. >>>=20 >>> Both cases are impossible now and blocks starting the DPDK >>> application: >>>=20 >>> ./dpdk-app --socket-limit 0 <...> >>> EAL: invalid parameters for --socket-limit >>> EAL: Invalid 'command line' arguments. >>> Unable to initialize DPDK: Invalid argument >>>=20 >>> Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") >>> Cc: stable@dpdk.org >>>=20 >>> Signed-off-by: Ilya Maximets >>> --- >>=20 >> That's kind of an odd parameter to pass, as it is assumed that if you=20 >> don't need any limitations or preallocated memory, you don't specify=20 >> these flags in the first place, but OK :) I personally would have liked a comment replacing the three lines stating t= hat total_mem of zero is fine as it only seems reasonable to document the r= eason total_mem can be zero. >>=20 >> Acked-by: Anatoly Burakov >=20 > Applied, thanks Regards, Keith