From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <keith.wiles@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 269A51B370 for <dev@dpdk.org>; Fri, 22 Dec 2017 14:59:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2017 05:59:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,441,1508828400"; d="scan'208";a="14443607" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 22 Dec 2017 05:59:02 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Dec 2017 05:59:02 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.21]) by fmsmsx158.amr.corp.intel.com ([169.254.15.128]) with mapi id 14.03.0319.002; Fri, 22 Dec 2017 05:59:02 -0800 From: "Wiles, Keith" <keith.wiles@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Thread-Topic: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules Thread-Index: AQHTeun0hk00m7uUiEyJwaAAkQjimaNPkh4AgAAWwoCAABosgIAAJ0OA Date: Fri, 22 Dec 2017 13:59:01 +0000 Message-ID: <E554161E-F956-4883-924F-9AA38F446C0C@intel.com> References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com> <2388140.F1AUfV8GGA@xps> <1e293147-9c72-9e77-97cb-9aabc9e5af39@nxp.com> <4919393.KhUSbVM1LT@xps> In-Reply-To: <4919393.KhUSbVM1LT@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.0.10] Content-Type: text/plain; charset="us-ascii" Content-ID: <2A4A551CA6B9F74EB3CD9E01097429F8@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 22 Dec 2017 13:59:04 -0000 > On Dec 22, 2017, at 5:38 AM, Thomas Monjalon <thomas@monjalon.net> wrote: >=20 > 22/12/2017 11:04, Hemant Agrawal: >> On 12/22/2017 2:13 PM, Thomas Monjalon wrote: >>> Hi, >>>=20 >>> 22/12/2017 06:57, Hemant Agrawal: >>>> This patch moves the Linux kernel modules code to a common place. >>>> - Separate the kernel module code from user space code. >>>> - The GPL-2.0 licensed code is separated from the BSD-3 licensed users= pace >>>> code >>>=20 >>> What is the benefit of separate things by license? >>=20 >> The separation makes it easy to identify and check the license. >>=20 >> Any patch introducing new file in *non-kern* folders shall not be=20 >> GPL-2.0 licensed. Or GPL-2.0 license is allowed only for kern folder. >=20 > The kernel modules are in DPDK only for historical reasons. > We should get rid of them, and rely only on upstream modules. >=20 > And it should be allowed to have kernel-related files elsewhere. > Examples: GPL tools or BPF code. >=20 >>> These modules are Linux modules, so they should be in the linuxapp dir. >>=20 >>=20 >> This is a cleaner separation w.r.t userspace/kernel space code. >> *kern* is a better placefolder for LKMs. >=20 > I prefer "kernel" name. The name should be related to Linux in some way, like linux_kern or linux_k= ernel or linux_modules (this is the one I prefer) this way it make it clear= which OS they are designed for. >=20 >> Also eal is not getting overloaded. >>=20 >> linuxapp is part of librte_eal. KNI is not related to EAL, but still=20 >> the kni kernel code is added to librte_eal under linuxapp. >=20 > Yes it makes sense. >=20 > More opinions/votes? >=20 >>> There are also some kernel modules in the bsdapp directory. >>=20 >> We can move them as well. Regards, Keith