From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 0C0BD2BAA for ; Mon, 22 Feb 2016 14:12:55 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 22 Feb 2016 05:12:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,484,1449561600"; d="scan'208";a="921207063" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 22 Feb 2016 05:12:52 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.113]) by IRSMSX102.ger.corp.intel.com ([169.254.2.97]) with mapi id 14.03.0248.002; Mon, 22 Feb 2016 13:12:51 +0000 From: "Kantecki, Tomasz" To: "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension Thread-Index: AdFtbvKp4IdUJ6UPTSq6OtcDX3CeYQ== Date: Mon, 22 Feb 2016 13:12:51 +0000 Message-ID: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTUyYjE2Y2EtZThkOS00NTlhLWI1NTYtNDQ5MmYzNjUxOWI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im51RlFvQ2NWT1JQa2p2TWRjTGM2cldnRnpQb3VNaTdwR2FYWDdhOW9IMDA9In0= x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal: Initial implementation of PQoS EAL extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2016 13:12:56 -0000 > EAL should not depend on the PQoS library. > Please could you hook the command line parsing and help to add these new > options from outside? Thanks for the feedback - we heard about dependency problem from a few sour= ces. = > The command line options may be convenient in some cases but not > straightforward for some applications. > >From now, the runtime options must be also configurable with an API. > Please consider a clean configuration API first in the library. > Then it can be hooked in the EAL command line. > A thought: should we move the EAL command line in a separate library with= a > hook API? Thanks for the suggestion and the feedback. Off the mail list, we received feedback that extending EAL commands is not = an option due to Intel Architecture nature of CAT. Consequently, we changed direction when working on V2 PQoS patches in roder= to: = - reduce DPDK PQoS code print and reuse existing open source code - remove IA specific options from EAL Current V2 patch, yet to be shared on the mail-list in a few days, implemen= ts a sample code (reuse of skeleton) that links against existing 01.org PQo= S library. This eliminates need for code included in V1 librte_pqos patch. The same sample code implements a C module that parses application specific= part of the command line with CAT configuration options (same format as V1= EAL command). The module is easy to re-use in other applications as needed. In the future, if there is a need to change this C module into a regular DP= DK library then we'll be happy to do so. Are you OK with concept behind V2 PQoS patch as described above? Thanks, Tomasz = -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.