From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0D13C101B for ; Tue, 19 Sep 2017 00:03:36 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 15:03:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,414,1500966000"; d="scan'208";a="136760342" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 18 Sep 2017 15:03:34 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Sep 2017 23:03:33 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by irsmsx155.ger.corp.intel.com ([169.254.14.70]) with mapi id 14.03.0319.002; Mon, 18 Sep 2017 23:03:33 +0100 From: "Kantecki, Tomasz" To: "alangordondewar@gmail.com" CC: "dev@dpdk.org" , Alan Dewar , "Dumitrescu, Cristian" Thread-Topic: [PATCH v2] sched: make RED scaling configurable Thread-Index: AQHTLHlTAdWatqZHJEequY1jmecuoKK6zyyg Date: Mon, 18 Sep 2017 22:03:33 +0000 Message-ID: References: <1504273290-5429-1-git-send-email-alan.dewar@att.com> <1505297744-15240-1-git-send-email-alan.dewar@att.com> In-Reply-To: <1505297744-15240-1-git-send-email-alan.dewar@att.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWZlMTk2MzEtYzVlNy00Zjc4LWFhM2ItZjI4YWVlY2MwZjZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZGU1wvakdYMlM1aUs3OFprXC9rdERuOXU4N1dCVkJHS1I2Q205S1h4SEtUMD0ifQ== dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 22:03:37 -0000 > -----Original Message----- > From: alangordondewar@gmail.com [mailto:alangordondewar@gmail.com] = > Sent: Wednesday, September 13, 2017 11:16 AM > To: Kantecki, Tomasz > Cc: dev@dpdk.org; Alan Dewar > Subject: [PATCH v2] sched: make RED scaling configurable > > From: Alan Dewar > > The RED code stores the maximum threshold is a 32-bit integer as a > pseudo fixed-point floating number with 10 fractional bits. Twelve > other bits are used to encode the filter weight, leaving just 10 bits > for the queue length. This limits the maximum queue length supported > by RED queues as 1024 packets. > > Move the "hard" definitions from red.h into config/common_base so that > RED scaling can be configured during build. > > Modified the RED unit-tests to use the new "soft" definition of > maximum-threshold from config/common_base in tests where it previously > used a hard coded limit of 1023. > > The RED unit-tests all successfully pass when the maximum-threshold is > configured as 8191 and the RED scaling factor is dropped to seven. > > Real-world testing has involved RED queue lengths of 8192 with multiple > different settings of the RED config parameters: min_th, max_th, wq_log2 > and maxp_inv. > > Signed-off-by: Alan Dewar > --- Thanks! The patch looks good to me. The only thing that potentially could be added is a brief description of th= e parameters in the common_base file. Acked-by: Tomasz Kantecki -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.