From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from www.guy-engineering.com (ns2.lexterieur.net [66.246.138.142]) by dpdk.org (Postfix) with ESMTP id 3C3E97E7E for ; Fri, 24 Oct 2014 19:14:21 +0200 (CEST) Received: from c-71-59-213-38.hsd1.or.comcast.net ([71.59.213.38] helo=[10.13.0.2]) by www.guy-engineering.com with esmtpsa (TLS1.0:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Xhiba-0005Zj-88; Fri, 24 Oct 2014 13:24:50 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Alexander Guy In-Reply-To: <6162830.h8YXoNDffD@xps13> Date: Fri, 24 Oct 2014 10:22:34 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1414107572-17073-1-git-send-email-alexander@andern.org> <6162830.h8YXoNDffD@xps13> To: Thomas Monjalon X-Mailer: Apple Mail (2.1878.6) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: fix building on Ubuntu-hybrids X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2014 17:14:21 -0000 On Oct 24, 2014, at 12:35 AM, Thomas Monjalon = wrote: >=20 > Please, could explain what is the file /proc/version_signature and why > it can be a check for Ubuntu kernel? Ubuntu provides /proc/version_signature to help with determining kernel = lineage; it doesn=92t exist in upstream kernels: = https://wiki.ubuntu.com/Kernel/FAQ#Kernel.2BAC8-FAQ.2BAC8-GeneralVersionRu= nning.How_can_we_determine_the_version_of_the_running_kernel.3F Commit a09b359d started gathering version information via = version_signature in order to enable certain Ubuntu-specific kernel = workarounds. If you have a kernel without this information (e.g. = upstream Linux v3.13 with an Ubuntu userspace), kni fails to build: CC [M] = /home/alexander/dpdk/build/build/lib/librte_eal/linuxapp/kni/e1000_82575.o= In file included from = /home/alexander/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h= :41:0, from = /home/alexander/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_hw.h:31= , from = /home/alexander/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_api.h:3= 1, from = /home/alexander/dpdk/build/build/lib/librte_eal/linuxapp/kni/e1000_82575.c= :38: = /home/alexander/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:386= 4:8: error: macro "UBUNTU_KERNEL_VERSION" requires 5 arguments, but only = 1 given = /home/alexander/dpdk/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:386= 4:8: error: "UBUNTU_KERNEL_VERSION" is not defined [-Werror=3Dundef] My logic for the change is: if the build system is running in an = environment that looks like Ubuntu, but can=92t gather enough = information to know if it should enable the kernel workarounds, it=92s = safe to not try to enable them at all. Thanks. Alexander