From: Ilya Matveychikov <matvejchikov@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] pdump: fix possible mbuf leak
Date: Thu, 9 Nov 2017 17:49:24 +0400 [thread overview]
Message-ID: <E85600CB-CC62-41CA-B265-3A480F129051@gmail.com> (raw)
If pdump_pktmbuf_copy_data() fails it's possible to have segment leak
as rte_pktmbuf_free() only handles m_dup chain but not the seg just
allocated and yet not chained.
Fixes: 278f9454 ("pdump: add new library for packet capture")
Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
lib/librte_pdump/rte_pdump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c
index 729e79a..1ca709d 100644
--- a/lib/librte_pdump/rte_pdump.c
+++ b/lib/librte_pdump/rte_pdump.c
@@ -153,6 +153,7 @@ pdump_pktmbuf_copy(struct rte_mbuf *m, struct rte_mempool *mp)
do {
nseg++;
if (pdump_pktmbuf_copy_data(seg, m) < 0) {
+ if (seg != m_dup) rte_pktmbuf_free(seg);
rte_pktmbuf_free(m_dup);
return NULL;
}
--
2.7.4
next reply other threads:[~2017-11-09 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 13:49 Ilya Matveychikov [this message]
2017-11-09 18:41 ` Ferruh Yigit
2017-11-10 13:54 ` [dpdk-dev] [PATCH 1/4] " Ilya V. Matveychikov
2017-11-10 13:55 ` [dpdk-dev] [PATCH] " Ilya V. Matveychikov
2017-11-12 3:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E85600CB-CC62-41CA-B265-3A480F129051@gmail.com \
--to=matvejchikov@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).