From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0086.outbound.protection.outlook.com [104.47.1.86]) by dpdk.org (Postfix) with ESMTP id 2697D1B1EC for ; Wed, 3 Oct 2018 20:56:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WUQGJtNY4xv2rghj5Xmy8t6EYGhfLxaUtftHbImPBCY=; b=PmChRY+Pz1CLXQCqgaEYE3Vmjq1WLdd7JSXG0RzbtnMu4SomUnUJTJmvWaLaGzvLcpBoJZaXtclARsLd6jDFOq1QbeEefY6A4x4s970VQX+/IyvB6ZqfeUTVfA9OD3tSe6SE+c5F87Kl1UXqscgIDeVXCr8TBm/rqbpmYXrqWQM= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Wed, 3 Oct 2018 18:56:23 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1185.024; Wed, 3 Oct 2018 18:56:23 +0000 From: Yongseok Koh To: Ophir Munk CC: "dev@dpdk.org" , Asaf Penso , Shahaf Shuler , Thomas Monjalon , Olga Shern Thread-Topic: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS Thread-Index: AQHUWz/ESBH47HIm1UmG4BuA5+cC8KUN3w0A Date: Wed, 3 Oct 2018 18:56:23 +0000 Message-ID: References: <1538588246-21436-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1538588246-21436-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4058; 6:9CgEDyLnjj/YlLei07szxo4R25x5glP3XHKH0RRmCaApzQHGkj+MK9iS/82AbCPbAPevhYfhVX5pc6rPYY6IU5BFOUANDOXSAiwinvgqrj12cyPDK/RYNcfzV9HekbJUBN9UxcrGGSnZnz5IfVuPcR0VRSo57gEa1LEKdagNJx6hYMFZBAGqMfrcQSbprfeLfr6LLxjeVSf+Z55aTkJPiX0uaDcUzLcM2WUeSBhLKENiFm+wREHufIjf/obluVYzAb3Ub74ZixBaobWWKt8rOAM9vz9CnJ/vuEvLg01UrvgSWtAN3wAtUHbq8K+M8Grrd0poXCf3by0wx5/0jTa9Jkuv8N1o/VdWCLwS0xf5miMjwyLp1pK425D1F88ezIVpB5WL1LpbbCW6iIKI2RjOpk6paZ9I8zZOPwcgjzOsWdQtkDottJzTv5iXzukBx5Zvu+4JrVbUWBFtGG6XQG2TQA==; 5:hyg7//tKFZaUnKS6oN6ufqzEHXCNyziBPEIBSRuLilALcZ9yZvh+Tyw/chs76oh0hwOJ78nhjLkhio2H6oXy14hFVf/jw5d8RRpsbZwqWGTHHxDyBIGbHbBNxRq9u+ibtDTd6lJ6TP4VDx2I2PWRy7vWQDJsrinxbBrGsejibtc=; 7:rGRWBHkxXGMMgjX9rWWQ5elF5VgmF4a81Z33P7d4kCe90lGj3DJhqKlYcRoZBzcD059Uq4mTZrGG7n5Iwgip1YzZzBAv5n048/pkyKMjkxjpgJ0yUk1DmMG/WbIkTfSmvXa5oUJZSzlppWku4vFqrw/XCyS7M/f6INOa6b+ep8Rvqhh406PC5Dl7ngO4e2MYX/5CMya01DUNrvPpreN6D3YmX650fyuqeZw/eqim/HcCC12quN//w6KyggHFWqu+ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 73956583-f9d6-4d0d-4901-08d62961ea31 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4058; x-ms-traffictypediagnostic: DB3PR0502MB4058: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231355)(944501410)(52105095)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(201708071742011)(7699051); SRVR:DB3PR0502MB4058; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4058; x-forefront-prvs: 0814A2C7A3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(376002)(346002)(396003)(366004)(39860400002)(199004)(189003)(5660300001)(25786009)(76176011)(6512007)(2616005)(476003)(11346002)(446003)(486006)(6486002)(6436002)(6506007)(81156014)(6636002)(53546011)(256004)(81166006)(186003)(6862004)(8936002)(37006003)(54906003)(68736007)(86362001)(99286004)(7736002)(26005)(102836004)(8676002)(4326008)(305945005)(107886003)(316002)(71190400001)(71200400001)(14454004)(2906002)(83716004)(6246003)(478600001)(3846002)(6116002)(82746002)(229853002)(2900100001)(5250100002)(66066001)(105586002)(33656002)(53936002)(97736004)(106356001)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: RlXQ77ykkiqigpLNSIsMbtAf6RQ3Gkg60oJSeXT3d+AXkZfQpFJIx+KaLI190Db2Vd/Q9HwSDArpDQzdBx/6F7Fn0Ohq6rG+hswnfo+ZtZoE5Z0JE8S7KwVonDGdFnk7q65Lf2LiqTMsVi5Pbv2jdKgvoGDayU01TfJ7SgVobMQNEt8UUOYLmmSy39Ktkknr1JqtxSjA6lby+tozSydKsYVJfBPutX3E/szBzDRVGuhm7LiVO6LD8Fjpud849d40WDjeBab/LhKBjw2RYlvN7YbfmSDFKv0Mhua9a0q1urQXbZ/d2F3DFkavyoQEGOQDDriI3D6oqTm5r2xMdtU5GZ+0+O/tXozgYs2Ls+u2P4w= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73956583-f9d6-4d0d-4901-08d62961ea31 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2018 18:56:23.5577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 18:56:25 -0000 > On Oct 3, 2018, at 10:37 AM, Ophir Munk wrote: >=20 > Applications which add an RSS flow must supply an RSS key table and an > RSS key length. If an application needs to add the default RSS flow it > should not care about the exact RSS default key table and its length. > By setting key length to 0 - the PMD will know that it should use the > default RSS key table and length. >=20 > Signed-off-by: Ophir Munk > --- > drivers/net/mlx5/mlx5_flow.c | 7 ++++--- Please rebase the code on top of the latest dpdk-next-net-mlx. Actually, it is better to rebase on top of PR#878. Thanks, Yongseok > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 3f548a9..18eacf5 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -2062,7 +2062,8 @@ struct mlx5_flow_tunnel_info { > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > &rss->level, > "tunnel RSS is not supported"); > - if (rss->key_len < MLX5_RSS_HASH_KEY_LEN) > + /* key_len 0 means using default RSS key */ > + if (rss->key_len > 0 && rss->key_len < MLX5_RSS_HASH_KEY_LEN) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > &rss->key_len, > @@ -2106,7 +2107,7 @@ struct mlx5_flow_tunnel_info { > memcpy((*flow->queue), rss->queue, > rss->queue_num * sizeof(uint16_t)); > flow->rss.queue_num =3D rss->queue_num; > - memcpy(flow->key, rss->key, MLX5_RSS_HASH_KEY_LEN); > + memcpy(flow->key, rss->key, rss->key_len); > flow->rss.types =3D rss->types; > flow->rss.level =3D rss->level; > flow->fate |=3D MLX5_FLOW_FATE_RSS; > @@ -2948,7 +2949,7 @@ struct mlx5_flow_tunnel_info { > flow->rss.queue_num); > if (!hrxq) > hrxq =3D mlx5_hrxq_new(dev, flow->key, > - MLX5_RSS_HASH_KEY_LEN, > + flow->rss.key_len, > verbs->hash_fields, > (*flow->queue), > flow->rss.queue_num, > --=20 > 1.8.3.1 >=20