DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Igor Ryzhov <iryzhov@arccn.ru>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] IXGBE error statistics
Date: Fri, 18 Sep 2015 08:04:54 +0000	[thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA612807DFD@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <E3D3F020-C366-4F57-92AC-41DCFE74B22D@arccn.ru>

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov
> Hello everyone.

Hi Igor,

> Investigating IXGBE driver I found an mspdc counter (MAC Short Packet
> Discard). And I am wondering why this counter is not used in the calculation
> of total RX errors (ierrors field in rte_eth_stats structure). Is it already a part
> of another counter, for example, rlec (Receive Length Error)? Or is it a bug?

There has been a discussion on list recently involving ixgbe stats, and certain
packets triggering multiple stats registers - the datasheet doesn't mention
this could be the case for the mspdc register, I will research this issue and
get back to you.

> Another one question is about incompleteness of rte_eth_stats structure.
> IXGBE and other drivers have a lot of counters but only a part of them is
> represented in rte_eth_stats. Is there any valuable reasons for that or it's
> just not implemented?

The rte_eth_stats struct presents the most general statistics that every NIC exposes.
In 2.1, and extended statistics API was added which allows NICs to expose stats
that are unique to that NIC. Currently ixgbe is the only driver that has the xstats API
implemented, I am working on patches to implement the functionality for the other
Intel drivers.

As part of testing the xstats implementation for each driver, I can test the exact
behavior of the mspdc counter, and if it is mis-counted this should become clear.

Cheers, -Harry

  reply	other threads:[~2015-09-18  8:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 21:23 Igor Ryzhov
2015-09-18  8:04 ` Van Haaren, Harry [this message]
2015-09-18 12:03   ` Igor Ryzhov
2015-09-21 13:45     ` Van Haaren, Harry
2015-09-21 14:09       ` Igor Ryzhov
2015-09-21 14:17       ` Kyle Larose
2015-09-21 14:22         ` Van Haaren, Harry
2015-10-27 10:26           ` Van Haaren, Harry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E923DB57A917B54B9182A2E928D00FA612807DFD@IRSMSX102.ger.corp.intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=dev@dpdk.org \
    --cc=iryzhov@arccn.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).