From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6CAA68E66 for ; Thu, 1 Oct 2015 10:00:34 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 01 Oct 2015 01:00:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,616,1437462000"; d="scan'208";a="816911995" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga002.fm.intel.com with ESMTP; 01 Oct 2015 01:00:31 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.84]) by irsmsx105.ger.corp.intel.com ([169.254.7.235]) with mapi id 14.03.0248.002; Thu, 1 Oct 2015 09:00:31 +0100 From: "Van Haaren, Harry" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v2 04/11] virtio: add xstats() implementation Thread-Index: AQHQ+2Q4k0RQGPXiXky2xmo8vxOmWZ5VR+WAgAD+szA= Date: Thu, 1 Oct 2015 08:00:30 +0000 Message-ID: References: <1443606022-13581-1-git-send-email-harry.van.haaren@intel.com> <1443606022-13581-5-git-send-email-harry.van.haaren@intel.com> <20150930104457.5ad45e08@urahara> In-Reply-To: <20150930104457.5ad45e08@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 04/11] virtio: add xstats() implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2015 08:00:34 -0000 > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > +/* [rt]x_qX_ is prepended to the name string here */ static const > > +struct rte_virtio_xstats_name_off rte_virtio_q_stat_strings[] =3D { > > + {"packets", offsetof(struct virtqueue, packets)}, > > + {"bytes", offsetof(struct virtqueue, bytes)}, > > + {"errors", offsetof(struct virtqueue, errors)}, } >=20 > I don't see the point of this. The point of xstats is to tell the applica= tion about > statistics not available through other means. > > These stats should be available already in the per queue stats. You're right - these stats are already available in the per-Q stats part of= rte_eth_stats. The virtio implementation of xstats is mostly framework code so we can add = other stats, for example packet size counters, in the near future. Thanks for reviewing, -Harry