Re: [dpdk-dev] [PATCH v3 0/2] i40e: Fix the statistics issue of i40e

["Van Haaren, Harry" <harry.van.haaren@intel.com>]

Hi Xutao,

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xutao Sun
> Sent: Thursday, October 29, 2015 8:02 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] i40e: Fix the statistics issue of i40e
> 
> The old statistics on i40e only counted the packets on ports.
> So the discarding packets on VSI were not counted.
> This patch is to make statistics for packets both on ports and VSI.

Indeed there is an issue in i40e stats, and adding the VSI stats to the port stats seems the right fix.

> Xutao Sun (2):
>   i40e: Fix the statistics issue of i40e
>   doc: update release notes
> 
>  doc/guides/rel_notes/release_2_1.rst |  5 +++++
>  drivers/net/i40e/i40e_ethdev.c       | 23 ++++++++++++++---------
>  2 files changed, 19 insertions(+), 9 deletions(-)

It is preferred to update docs in the same patch as a bugfix: one patch should suffice for a bug-fix and adding a note that it has been fixed.

Perhaps you edited the wrong release file? The next release changes are described in release_2_2.rst

Would you send a v4 with release_2_2 updated, and then I'll test and ack?
Cheers, -Harry