From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <harry.van.haaren@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id E1218E72
 for <dev@dpdk.org>; Tue, 10 Nov 2015 16:46:18 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 10 Nov 2015 07:46:17 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,271,1444719600"; d="scan'208";a="816364454"
Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3])
 by orsmga001.jf.intel.com with ESMTP; 10 Nov 2015 07:46:14 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.251]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0248.002;
 Tue, 10 Nov 2015 15:46:13 +0000
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Stephen Hemminger <shemming@brocade.com>
Thread-Topic: [PATCH] ixgbe: fix crc-strip enable changing rx bytes
Thread-Index: AQHRGv6sRZAQDHKl9kmAd8Bg6cUg056T4l2AgAGFNzA=
Date: Tue, 10 Nov 2015 15:46:13 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA612836549@IRSMSX102.ger.corp.intel.com>
References: <1447080904-27512-1-git-send-email-harry.van.haaren@intel.com>
 <20151109083209.7c1eb27b@xeon-e3>
In-Reply-To: <20151109083209.7c1eb27b@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-inteldataclassification: CTP_PUBLIC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiIzMTdlMjNkZC1kOTk5LTRkMDgtYjg3Zi03OGYxYzM3M2E4Y2YiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfUFVCTElDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidHpSclVCOENLVjdZK3FoTThwTDhxR3RnUkp1aWRKR2FCTnZFSWFKVG1lbz0ifQ==
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix crc-strip enable changing rx bytes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Nov 2015 15:46:20 -0000

Hi Stephen,

> From: Stephen Hemminger [mailto:shemming@brocade.com]
> Subject: Re: [PATCH] ixgbe: fix crc-strip enable changing rx bytes
>=20
> Harry van Haaren <harry.van.haaren@intel.com> wrote:
> > <snip>
> > This patch reads the CRC strip register, and when enabled adds 4 bytes
> > to the total bytes recieved counter for each received packet.
> > <snip>
>=20
> NAK.
>=20
> The CRC should never be part of rx/tx statistics.
>=20
> The problem with putting CRC in statistics is the behavior introduces a
> device and setting dependency. This is a disaster for generic programs (l=
ike vRouter)
> that want to work across multiple hardware and virtual NIC's.
>=20
> Also, Linux, BSD, and Unix do not include CRC in reported bytes for netwo=
rk
> interfaces.
>=20
> Please fix up my original patch to work for both settings, or I can do it=
.

I understand your point that generic programs should not require knowledge =
of if CRC bytes are included in the packet-size or not, and agree that this=
 should be consistent in DPDK / Linux / BSD etc.

I will rework the PMDs to report byte counters without CRC bytes, and mark =
this patch as superseded.

-Harry