From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: restore imissed stat counter
Date: Tue, 15 Dec 2015 16:41:59 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA61283FE68@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1450195501-9196-1-git-send-email-robin.jarry@6wind.com>
> From: Robin Jarry [mailto:robin.jarry@6wind.com]
> Subject: [PATCH] ixgbe: restore imissed stat counter
>
> This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
>
> The ierrors counter still includes imissed for ixgbe. This behaviour is
> not consistent amongst all drivers. Another patch may be needed to unify
> the meaning of the ierrors counter.
>
> Fixes: 5e50ad1c1b63 ("ixgbe: add specific stats")
>
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
There is work to be done to allow easier distinction between
drops due to the host, and errors due to bad packets.
Until that work is done, write the dropped packet count to imissed, so:
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2015-12-15 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 16:05 Robin Jarry
2015-12-15 16:41 ` Van Haaren, Harry [this message]
2015-12-15 17:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA61283FE68@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=robin.jarry@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).