From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 202809231 for ; Tue, 26 Jan 2016 12:19:22 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 26 Jan 2016 03:19:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,350,1449561600"; d="scan'208";a="734426023" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 26 Jan 2016 03:19:21 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.97]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0248.002; Tue, 26 Jan 2016 11:19:20 +0000 From: "Van Haaren, Harry" To: "Qiu, Michael" , "david.marchand@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] eal: add function to check if primary proc alive Thread-Index: AQHRU4YWhvADP+xDWU6YXyDiXb5ALp8NrSdQ Date: Tue, 26 Jan 2016 11:19:19 +0000 Message-ID: References: <1453296322-1210-1-git-send-email-harry.van.haaren@intel.com> <533710CFB86FA344BFBF2D6802E6028622F2180B@SHSMSX101.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E6028622F221CB@SHSMSX101.ccr.corp.intel.com> <533710CFB86FA344BFBF2D6802E6028622F22C3C@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F22C3C@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTkxN2I0MDctM2U0MS00NTJjLTlkOGItMTMyZmUyMjkxNTg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS40LjEwLjE5IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJjSXppTmtoYUJqRnRmWnBIMlpmN2QxMU5CUlNOZnl6UHZ1WHJPa25TRzg9In0= x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: add function to check if primary proc alive X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 11:19:23 -0000 > From: Qiu, Michael > > Whatever work the secondary was performing (in its own address space) > > won't be directly changed by the primary being killed, because the > > shared config and hugepages stay (EAL "cleans up" when the primary > > is re-launched, not on quit). >=20 > OK, when primary quit or be killed, the queues will be freed, it will > be a potential issue when secondary try to access, maybe I'm wrong. The use-case for this patch is monitoring statistics and fault-detection. That involves reading registers directly from the NIC, and the NIC rx/tx queues are not used. I think you are right that using the rx/tx queues from a secondary process when they have been cleaned-up by the primary process will indeed cause issues. If there is a valid use-case where both primary and secondary processes will be forwarding packets on the same NIC, this issue should be discussed in more detail. In its current state, this patch solves a problem for the use case of a primary process forwarding packets, and a secondary process monitoring and providing fault-detection. -Harry