From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 04694293B for ; Wed, 6 Apr 2016 13:16:46 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 06 Apr 2016 04:16:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="926593812" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2016 04:16:46 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.19]) by IRSMSX154.ger.corp.intel.com ([169.254.12.173]) with mapi id 14.03.0248.002; Wed, 6 Apr 2016 12:16:44 +0100 From: "Van Haaren, Harry" To: Thomas Monjalon CC: "'David Harton (dharton)'" , "dev@dpdk.org" , "Tahhan, Maryam" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 Thread-Index: AQHRj2TGC1w7MzqL2k2CwLQlTw7bAZ97pzcAgAD4zID///wHAIAAI6hg Date: Wed, 6 Apr 2016 11:16:43 +0000 Message-ID: References: <1459879089-3430-1-git-send-email-harry.van.haaren@intel.com> <1955261.zYXyGahjVu@xps13> <27546869.TpcjJvEkXE@xps13> In-Reply-To: <27546869.TpcjJvEkXE@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzE4MjQwYWYtODZmNC00MTIzLThlMjAtZmUwODdhMjZmZjRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iko2ZFRJak5KWktuN28rSzNDWHluZ2xCeWQ1R2wyVFZXMXpCOUR2K1FodTg9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 11:16:47 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Subject: Re: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 > > The issue we are going to fix is that currently PMDs copy strings when = retrieving > statistics, which causes unnecessary overhead. The implementation is not = decided yet, but > using an int->value mapping seems logical. > I am not sure performance is so much critical when retrieving statistics. In the previous discussion David was concerned about performance impact of string copies, are those concerns still present David? > The extended stats can be infinitely extended. So a string identifier see= ms > a lot more natural. I'm not suggesting that the string identifier is removed totally. > I do not agree to add a new numeric identifier in the API each time a dri= ver > wants to report a specific statistic for debugging purpose.=20 And I agree - the ints are just an index to xstats arrays, no eth-dev wide = enums here. The proposal is to make the API more flexible, see example: http://thread.gmane.org/gmane.comp.networking.dpdk.devel/31728/focus=3D3279= 5 This more flexible API would allow other types of information about statistics be retrieved too. For now, the sent patch announces that the API/ABI may change, and we can discuss details of API as development starts.