From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ameen.rahman@qlogic.com" <ameen.rahman@qlogic.com>,
"harish.patil@qlogic.com" <harish.patil@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
Date: Wed, 6 Apr 2016 14:32:54 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6128A446D@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1459903028-3329-3-git-send-email-rasesh.mody@qlogic.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rasesh Mody
> Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
Hi Rasesh,
> + snprintf(xstats[num].name, sizeof(xstats[num].name), "brb_drops");
I don't understand what a "brb" drop is.
> + snprintf(xstats[num].name, sizeof(xstats[num].name), "tx_pfc");
Similarly here, and with some other of the xstats strings, it doesn't
become clear to me what exactly the value represents.
"mac_filter_discard" is descriptive and readable, but the next stat
has "mf_tag_discard" - these small inconsistencies make it much harder
(impossible?) to scrap the xstats strings and retrieve useful metadata.
I'll suggest leaving the xstats implementation part of this patch until
the next release, and we can align on the names of the stats.
-Harry
next prev parent reply other threads:[~2016-04-06 14:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 0:37 [dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation Rasesh Mody
2016-04-06 0:37 ` [dpdk-dev] [PATCH v3 2/4] bnx2x: Fix Tx Performance Rasesh Mody
2016-04-06 0:37 ` [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get Rasesh Mody
2016-04-06 14:32 ` Van Haaren, Harry [this message]
2016-04-07 5:10 ` Rasesh Mody
2016-05-04 5:41 ` Rasesh Mody
2016-04-06 0:37 ` [dpdk-dev] [PATCH v3 4/4] bnx2x: Update PMD version to 1.0.1.1 Rasesh Mody
2016-04-06 14:32 ` [dpdk-dev] [PATCH v3 1/4] bnx2x: Update documentation Bruce Richardson
2016-04-07 5:08 ` Rasesh Mody
2016-04-07 18:22 ` [dpdk-dev] [PATCH] " Rasesh Mody
2016-04-07 21:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA6128A446D@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=ameen.rahman@qlogic.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).