From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9A89A14EC for ; Mon, 6 Feb 2017 11:25:21 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 06 Feb 2017 02:25:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,341,1477983600"; d="scan'208";a="61652956" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga005.fm.intel.com with ESMTP; 06 Feb 2017 02:25:19 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002; Mon, 6 Feb 2017 10:25:19 +0000 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" , "Richardson, Bruce" Thread-Topic: [PATCH v2 07/15] event/sw: add support for event queues Thread-Index: AQHSgFsDIBLHX5ew9UC20l4IRbpDKKFbw9VQ Date: Mon, 6 Feb 2017 10:25:18 +0000 Message-ID: References: <1484580885-148524-1-git-send-email-harry.van.haaren@intel.com> <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com> <1485879273-86228-8-git-send-email-harry.van.haaren@intel.com> <20170206092509.GF25242@localhost.localdomain> In-Reply-To: <20170206092509.GF25242@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGRlODYyOWItNDFiNi00MDRjLTg3MGEtMGNkYmY1NzIwNmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvS1JacEpwTllENzI2bFpMYzBuanpOVHFBYkQ5MXp3ajg1TEJEcjFVaTBBPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 07/15] event/sw: add support for event queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2017 10:25:22 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, February 6, 2017 9:25 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: Re: [PATCH v2 07/15] event/sw: add support for event queues >=20 > On Tue, Jan 31, 2017 at 04:14:25PM +0000, Harry van Haaren wrote: > > From: Bruce Richardson > > > > Add in the data structures for the event queues, and the eventdev > > functions to create and destroy those queues. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Harry van Haaren > > --- > > drivers/event/sw/iq_ring.h | 176 ++++++++++++++++++++++++++++++++++++= ++++++++ > > drivers/event/sw/sw_evdev.c | 158 ++++++++++++++++++++++++++++++++++++= +++ > > drivers/event/sw/sw_evdev.h | 75 +++++++++++++++++++ > > 3 files changed, 409 insertions(+) > > create mode 100644 drivers/event/sw/iq_ring.h > > > > + */ > > + > > +/* > > + * Ring structure definitions used for the internal ring buffers of th= e > > + * SW eventdev implementation. These are designed for single-core use = only. > > + */ >=20 > If I understand it correctly, IQ and QE rings are single producer and > single consumer rings. By the specification, multiple producers through > multiple ports can enqueue to the event queues at a time.Does SW implemen= tation > support that? or am I missing something here? You're right that the IQ and QE rings are Single Producer, Single Consumer = rings. More specifically, the QE is a ring for sending rte_event structs be= tween cores, while the IQ ring is optimized for internal use in the schedul= er core - and should not be used to send events between cores. Note that th= e design of the SW scheduler includes a central core for performing schedul= ing. In other works, the QE rings transfer events from the worker core to the sc= heduler - and the scheduler pushes the events into what you call the "event= queues" (aka, the atomic/ordered queue itself). These "event queues" are I= Q instances. On egress from the scheduler, the event passes through a QE ri= ng to the worker. The result is that despite that only SP/SC rings are used, multiple workers= can enqueue to any event queue.