From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1C1902C49 for ; Fri, 10 Mar 2017 10:48:09 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 10 Mar 2017 01:48:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,140,1486454400"; d="scan'208";a="1106960723" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 10 Mar 2017 01:48:07 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.230]) by IRSMSX107.ger.corp.intel.com ([169.254.10.3]) with mapi id 14.03.0248.002; Fri, 10 Mar 2017 09:48:06 +0000 From: "Van Haaren, Harry" To: Stephen Hemminger , "Horton, Remy" CC: "dev@dpdk.org" , Thomas Monjalon , "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf for latencystats Thread-Index: AQHSmPHXx7ZGvUS8rECqliSfg1p0raGM3X4AgADzM3A= Date: Fri, 10 Mar 2017 09:48:06 +0000 Message-ID: References: <1489076734-31474-1-git-send-email-remy.horton@intel.com> <1489076734-31474-6-git-send-email-remy.horton@intel.com> <20170309110226.2ce09891@xeon-e3> In-Reply-To: <20170309110226.2ce09891@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWZjZDg5MjctMTIxYS00YjFmLTgyMmEtYzc4NmQ3YTdmZGVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJ5cUF5K2pHeFNtb1VWZ0gxNWZcL3l3T1RJUWpJXC9JZDVGaFZcL0NVamtMTklvPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf for latencystats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:48:10 -0000 > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Cc: dev@dpdk.org; Van Haaren, Harry ; Thomas = Monjalon > ; Pattan, Reshma > Subject: Re: [dpdk-dev] [PATCH v11 5/7] mbuf: add a timestamp to the mbuf= for > latencystats >=20 > On Thu, 9 Mar 2017 16:25:32 +0000 > Remy Horton wrote: >=20 > > From: Harry van Haaren > > > > This commit adds a uint64_t to the mbuf struct, > > allowing collection of latency and jitter statistics > > by measuring packet I/O timestamps. This change is > > required by the latencystats library. > > > > Signed-off-by: Reshma Pattan > > Signed-off-by: Harry van Haaren > > --- > > lib/librte_mbuf/rte_mbuf.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index ce57d47..e0dad6e 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -514,6 +514,9 @@ struct rte_mbuf { > > > > /** Timesync flags for use with IEEE1588. */ > > uint16_t timesync; > > + > > + /** Timestamp for measuring latency. */ > > + uint64_t timestamp; > > } __rte_cache_aligned; > > > > /** >=20 > This creates a hole in the mbuf structure, and won't apply to current > version of mbuf that has priv_size. This series was previously targeted to 17.02 when the mbuf rework was on th= e horizon, so placement of the timestamp was not as critical as it is now. = Given the mbuf rework[1] is currently in progress, perhaps it is smarter to= remove this patch from the patchset and depend on the mbuf rework patchset= to add the timestamp instead. The latency stat library should probably also set the new PKT_RX_TIMESTAMP = field in the mbuf[2]. [1] mbuf rework http://dpdk.org/dev/patchwork/patch/21601/ [2] mbuf timestamp http://dpdk.org/dev/patchwork/patch/21607/