From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 90DB12C27 for ; Thu, 13 Apr 2017 11:36:50 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 13 Apr 2017 02:36:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="76893512" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga004.jf.intel.com with ESMTP; 13 Apr 2017 02:36:48 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Thu, 13 Apr 2017 10:36:08 +0100 From: "Van Haaren, Harry" To: Shahaf Shuler , "thomas.monjalon@6wind.com" CC: "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags Thread-Index: AQHStBcOVppq+fKdEkmSQhh4nIe+baHC909Q Date: Thu, 13 Apr 2017 09:36:08 +0000 Message-ID: References: <20170413052927.82842-1-shahafs@mellanox.com> In-Reply-To: <20170413052927.82842-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWFjMjI4OGEtNDdjNS00OGYwLTg0MTUtODRiMWFlZmIyNGQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJSeFwvNnJQTzEwVSsyTDJWRUpsUEF1UmJ2ZzUzUndLbHZ3WU1waXdXSVZaOD0ifQ== x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 09:36:51 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, April 13, 2017 6:29 AM > To: thomas.monjalon@6wind.com > Cc: adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict fla= gs >=20 > Compilation error seen while compiling mlx5 in debug mode > under RHEL 7.3: >=20 > rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension > [-Werror=3Dpedantic] >=20 > Address it by removing the unnecessary bit-field width limitation. >=20 > Fixes: d52268a8b24b ("ethdev: expose device states") >=20 > Signed-off-by: Shahaf Shuler > --- > lib/librte_ether/rte_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h > index d07253874..2d1bc12aa 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1667,7 +1667,7 @@ struct rte_eth_dev { > * received packets before passing them to the driver for transmission. > */ > struct rte_eth_rxtx_callback *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT]= ; > - enum rte_eth_dev_state state:8; /**< Flag indicating the port state */ > + enum rte_eth_dev_state state; /**< Flag indicating the port state */ > } __rte_cache_aligned; >=20 > struct rte_eth_dev_sriov { What is the guidelines of changing ABI of an @internal structure? If I understand correctly, this @internal structure shouldn't be allocated = in the app - so we can extend it at the end without breaking ABI. Since the state is at the end of the struct, I think this change is safe. ABI Validate tool with GCC 5.4.0 says ABI compatible, so Acked-by: Harry van Haaren