From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1D5692BB1 for ; Fri, 14 Apr 2017 17:28:05 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2017 08:28:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,199,1488873600"; d="scan'208";a="89406493" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga006.fm.intel.com with ESMTP; 14 Apr 2017 08:28:03 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by IRSMSX152.ger.corp.intel.com ([169.254.6.231]) with mapi id 14.03.0319.002; Fri, 14 Apr 2017 16:28:03 +0100 From: "Van Haaren, Harry" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH] event/sw: fix events mis-identified as needing reorder Thread-Index: AQHStTJf11bJMDgvp0ior9CE2FA53KHE/EHg Date: Fri, 14 Apr 2017 15:28:01 +0000 Message-ID: References: <20170414151815.12850-1-bruce.richardson@intel.com> In-Reply-To: <20170414151815.12850-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTk5ZTQxNjgtZDAyZS00ZTk2LTk3ZGItYzRlNjM1MWJlNzAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBlYVI4QUpOUjRJeE9RcktlSlNIUkRKYnVvbFVhWENMdG91TmtZd0hpRHc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] event/sw: fix events mis-identified as needing reorder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 15:28:06 -0000 > From: Richardson, Bruce > Sent: Friday, April 14, 2017 4:18 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce > Subject: [PATCH] event/sw: fix events mis-identified as needing reorder >=20 > When taking events from a port, we checked the history list to check if t= he > event needed to be put back in order i.e. originally came from a reordere= d > queue type. The check for reordering involved checking if the reorder > buffer entry pointer was null. However, after that pointer was used it wa= s > never cleared to null again. >=20 > This caused problems when we had mixed reordered and atomic or parallel > events, as the events from the latter two queue types were misidentified = as > needing reordering. This let in some cases to crashes, but mostly led to > dropping events, and then application lock-up. >=20 > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") >=20 > Signed-off-by: Bruce Richardson +CC Thomas, would you pick this directly to master please, as no next-event= dev will be merged, thanks. Acked-by: Harry van Haaren