From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 95E9C3B5 for ; Fri, 28 Apr 2017 13:09:45 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 04:09:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="94936423" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga005.fm.intel.com with ESMTP; 28 Apr 2017 04:09:43 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 12:09:42 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.153]) by irsmsx155.ger.corp.intel.com ([169.254.14.202]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 12:09:42 +0100 From: "Van Haaren, Harry" To: "Jastrzebski, MichalX K" , "dev@dpdk.org" CC: "Jain, Deepak K" , "Kozak, KubaX" Thread-Topic: [PATCH v1 2/6] ethdev: retrieve xstats by ID Thread-Index: AQHSv2T2vGJqx3qLqUGBblTq34DbUqHaoOGQ Date: Fri, 28 Apr 2017 11:09:41 +0000 Message-ID: References: <20170427144240.10188-1-michalx.k.jastrzebski@intel.com> <20170427144240.10188-3-michalx.k.jastrzebski@intel.com> In-Reply-To: <20170427144240.10188-3-michalx.k.jastrzebski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzNiMWVhZjMtOTEwYi00MzcwLTg1NGYtYmJkY2ZhZjYwODZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJ3MTRqK09aM1h5bDdRaW5VVWdRMU9oNlpFRVwvNHFjTGdHK2pnWHJhRGFjPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 2/6] ethdev: retrieve xstats by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 11:09:46 -0000 > From: Jastrzebski, MichalX K > Sent: Thursday, April 27, 2017 3:43 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K ; > Kozak, KubaX > Subject: [PATCH v1 2/6] ethdev: retrieve xstats by ID >=20 > From: Kuba Kozak >=20 > Extended xstats API in ethdev library to allow grouping of stats > logically so they can be retrieved per logical grouping managed > by the application. > Added new functions rte_eth_xstats_get_names_by_id and > rte_eth_xstats_get_by_id using additional arguments (in compare > to rte_eth_xstats_get_names and rte_eth_xstats_get) - array of ids > and array of values. >=20 > doc: add description for modified xstats API > Documentation change for new extended statistics API functions. > The old API only allows retrieval of *all* of the NIC statistics > at once. Given this requires a MMIO read PCI transaction per statistic > it is an inefficient way of retrieving just a few key statistics. > Often a monitoring agent only has an interest in a few key statistics, > and the old API forces wasting CPU time and PCIe bandwidth in retrieving > *all* statistics; even those that the application didn't explicitly > show an interest in. > The new, more flexible API allow retrieval of statistics per ID. > If a PMD wishes, it can be implemented to read just the required > NIC registers. As a result, the monitoring application no longer wastes > PCIe bandwidth and CPU time. >=20 > Signed-off-by: Kuba Kozak Acked-by: Harry van Haaren