From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E50A7374 for ; Thu, 29 Jun 2017 13:14:15 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2017 04:14:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,280,1496127600"; d="scan'208";a="986636873" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga003.jf.intel.com with ESMTP; 29 Jun 2017 04:14:01 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX154.ger.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0319.002; Thu, 29 Jun 2017 12:14:00 +0100 From: "Van Haaren, Harry" To: 'Jerin Jacob' CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Wiles, Keith" , "Richardson, Bruce" Thread-Topic: [PATCH 3/6] service cores: EAL init changes Thread-Index: AQHS7AACE7qhwXtTdkyYTj78LNp7YqI3DhMAgAGuF5A= Date: Thu, 29 Jun 2017 11:13:59 +0000 Message-ID: References: <1498208779-166205-1-git-send-email-harry.van.haaren@intel.com> <1498208779-166205-3-git-send-email-harry.van.haaren@intel.com> <20170626125459.GC5612@jerin> In-Reply-To: <20170626125459.GC5612@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDQ4ZGRjNDItMjYwNC00MTRmLWJkNDQtZjA5ZGY1MWI0ZWViIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNi41LjkuMyIsIlRydXN0ZWRMYWJlbEhhc2giOiJNTEJoTVNxbVRXTjl1MVBKVmhucDBVYVRNVUxNeVwvY1k1cklOUUZJSmZxbz0ifQ== x-ctpclassification: CTP_PUBLIC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/6] service cores: EAL init changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 11:14:16 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > This commit shows the changes required in rte_eal_init() > > to transparently launch the service threads. The threads > > are launched into the service worker functions here because > > after rte_eal_init() the application is not gauranteed to > > call any other DPDK API. > > > > As the registration of services happens at initialization > > time, the services that require CPU time are already available > > when we reach the end of rte_eal_init(). > > > > Signed-off-by: Harry van Haaren > > --- > > lib/librte_eal/linuxapp/eal/eal.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxap= p/eal/eal.c >=20 > Need to add bsdapp implementation for the same. Done. > > + /* initialize service core threads and default service-core mapping *= / > > + struct rte_config *config =3D rte_eal_get_configuration(); > > + uint32_t service_cores[RTE_MAX_LCORE]; > > + int count =3D rte_service_core_list(service_cores, RTE_MAX_LCORE); > > + for (i =3D 0; i < count; i++) { > > + config->lcore_role[service_cores[i]] =3D ROLE_SERVICE; >=20 > Can we move this change inside rte_service_core_start() itself? > otherwise every application needs to the same. Right? Done, nice, this removes the requirement to access rte_config, which I didn= 't like having there.