From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D61073772 for ; Fri, 30 Jun 2017 11:14:25 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 30 Jun 2017 02:14:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,285,1496127600"; d="scan'208";a="1188942585" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 30 Jun 2017 02:14:23 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by IRSMSX106.ger.corp.intel.com ([169.254.8.236]) with mapi id 14.03.0319.002; Fri, 30 Jun 2017 10:14:23 +0100 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Eads, Gage" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Rao, Nikhil" Thread-Topic: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant Thread-Index: AQHS8OLypJfWXAwPGkKD89BxmzmfsaI9FBhQ///7N4CAABEFUA== Date: Fri, 30 Jun 2017 09:14:22 +0000 Message-ID: References: <20170629141956.23132-1-jerin.jacob@caviumnetworks.com> <20170629141956.23132-2-jerin.jacob@caviumnetworks.com> <20170630091156.GA12111@jerin> In-Reply-To: <20170630091156.GA12111@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmE4ZGQxNGQtMDFjYi00YmQyLTkwNWYtNTdiNGEzNTRhY2VjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJCeWVvdXd5NDF5K0QzK08yRWh2OURWV2JGckNpYTlMWnRuM0NpblwvN2xFPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 09:14:26 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Friday, June 30, 2017 10:12 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce ; hemant.= agrawal@nxp.com; > Eads, Gage ; nipun.gupta@nxp.com; Vangati, Narender > ; Rao, Nikhil > Subject: Re: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enque= ue new op variant >=20 > -----Original Message----- > > Date: Fri, 30 Jun 2017 08:40:06 +0000 > > From: "Van Haaren, Harry" > > To: Jerin Jacob , "dev@dpdk.org" > > > > CC: "Richardson, Bruce" , > > "hemant.agrawal@nxp.com" , "Eads, Gage" > > , "nipun.gupta@nxp.com" , > > "Vangati, Narender" , "Rao, Nikhil" > > > > Subject: RE: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enq= ueue > > new op variant > > > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > > Sent: Thursday, June 29, 2017 3:20 PM > > > To: dev@dpdk.org > > > > > diff --git a/drivers/event/octeontx/ssovf_evdev.c > b/drivers/event/octeontx/ssovf_evdev.c > > > index 8dc7b2ef8..0d0c6a186 100644 > > > --- a/drivers/event/octeontx/ssovf_evdev.c > > > +++ b/drivers/event/octeontx/ssovf_evdev.c > > > @@ -158,6 +158,7 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev) > > > dev->schedule =3D NULL; > > > dev->enqueue =3D ssows_enq; > > > dev->enqueue_burst =3D ssows_enq_burst; > > > + dev->enqueue_new_burst =3D ssows_enq_burst; > > > dev->dequeue =3D ssows_deq; > > > dev->dequeue_burst =3D ssows_deq_burst; > > > > > > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.= c > > > index fe2a61e2f..951ad1b33 100644 > > > --- a/drivers/event/sw/sw_evdev.c > > > +++ b/drivers/event/sw/sw_evdev.c > > > @@ -796,6 +796,7 @@ sw_probe(struct rte_vdev_device *vdev) > > > dev->dev_ops =3D &evdev_sw_ops; > > > dev->enqueue =3D sw_event_enqueue; > > > dev->enqueue_burst =3D sw_event_enqueue_burst; > > > + dev->enqueue_new_burst =3D sw_event_enqueue_burst; > > > dev->dequeue =3D sw_event_dequeue; > > > dev->dequeue_burst =3D sw_event_dequeue_burst; > > > dev->schedule =3D sw_event_schedule; > > > > > > I think it is possible to do this pointer-setting of new_burst() in eve= ntdev.c, instead > of adding the new_burst() to each PMD individually? > > During rte_eventdev_configure(), if the dev->enqueue_new_burst() functi= on is NULL, just > point it at the ordinary one; >=20 > I thought so, But it will break in multi process use case as on probe() w= e are > updating the callbacks for secondary process. Doing it in probe() may be = very > early as some PMD may update the callback anywhere on or before rte_event= dev_start(). >=20 > Thoughts? Ah I forgot about the multi-proc init during my review. The current solutio= n is more appropriate then, so this version=20 Acked-by: Harry van Haaren