From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 953FB5398 for ; Tue, 11 Jul 2017 16:11:19 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2017 07:11:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,346,1496127600"; d="scan'208";a="1194013138" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2017 07:11:16 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 11 Jul 2017 15:11:15 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.211]) by irsmsx111.ger.corp.intel.com ([169.254.2.25]) with mapi id 14.03.0319.002; Tue, 11 Jul 2017 15:11:15 +0100 From: "Van Haaren, Harry" To: Jerin Jacob CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Wiles, Keith" , "Richardson, Bruce" Thread-Topic: [PATCH v4 2/7] service cores: EAL init changes Thread-Index: AQHS9z/j6NkdowpJ0Uyy8pQfrQv9kaJOMyyAgAB9MwA= Date: Tue, 11 Jul 2017 14:11:15 +0000 Message-ID: References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com> <1499445667-32588-1-git-send-email-harry.van.haaren@intel.com> <1499445667-32588-3-git-send-email-harry.van.haaren@intel.com> <20170711074215.GA27939@jerin> In-Reply-To: <20170711074215.GA27939@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjlkMzhhY2EtZGQ4OS00ODZlLWIwOTQtYWE2YTQ1NGVkYjc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhCclNGTXRkaVdqV0RYTWJNWlA2UjhBR0JodVwvNWRMUjZ6K2RuNm55dUZ3PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/7] service cores: EAL init changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 14:11:20 -0000 > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, July 11, 2017 8:42 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; thomas@monjalon.net; Wiles, Keith ; Richardson, > Bruce > Subject: Re: [PATCH v4 2/7] service cores: EAL init changes > > + /* initialize default services configuration */ > > + uint32_t service_cores[RTE_MAX_LCORE]; > > + int count =3D rte_service_lcore_list(service_cores, RTE_MAX_LCORE); > > + for (i =3D 0; i < count; i++) > > + rte_service_lcore_start(service_cores[i]); > > + ret =3D rte_service_set_default_mapping(); > > + if (ret) { > > + rte_errno =3D ENOEXEC; > > + return -1; > > + } >=20 > How about moving, rte_service_lcore_start() inside > rte_service_set_default_mapping() so that rte_eal_init() level change wil= l be > less in linuxapp and bsdapp?(and both changes are tightly coupled too). >=20 > You could change the function name to rte_service_enable_default_mapping(= ) > or something like that to include rte_service_lcore_start() start change. Good idea - done. Does indeed make things cleaner - thanks! > With that change: > Acked-by: Jerin Jacob Added to patch! Cheers, -Harry