From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A120A7CC0 for ; Mon, 4 Sep 2017 15:38:04 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 04 Sep 2017 06:38:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="147933758" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga006.fm.intel.com with ESMTP; 04 Sep 2017 06:38:03 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Sep 2017 14:36:43 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 14:36:43 +0100 From: "Van Haaren, Harry" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds Thread-Index: AQHTIwuui9ipfC6STkWvEMh7L9Xqv6KkvCSQ Date: Mon, 4 Sep 2017 13:36:42 +0000 Message-ID: References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-2-bruce.richardson@intel.com> In-Reply-To: <20170901100416.80264-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDE1YTc5ZDgtMjI5Yy00ZjE1LTk3OTktYzI3ZGFmMGU1YTAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImFETXFMVG0yaVlzdkF1NThDTUNISVJBcld2c2Rpd3RUZGRFUHdOb2syYWs9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 13:38:05 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, September 1, 2017 11:04 AM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for m= eson & ninja builds >=20 > To build with meson and ninja, we need some initial infrastructure in > place. The build files for meson always need to be called "meson.build", > and options get placed in meson_options.txt >=20 > This commit adds a top-level meson.build file, which sets up the global > variables for tracking drivers, libraries, etc., and then includes other > build files, before finishing by writing the global build configuration > header file and a DPDK pkgconfig file at the end, using some of those sam= e > globals. >=20 > From the top level build file, the only include file thus far is for the > config folder, which does some other setup of global configuration > parameters, including pulling in architecture specific parameters from an > architectural subdirectory. A number of configuration build options are > provided for the project to tune a number of global variables which will = be > used later e.g. max numa nodes, max cores, etc. These settings all make > their way to the global build config header "rte_build_config.h". There i= s > also a file "rte_config.h", which includes "rte_build_config.h", and this > file is meant to hold other build-time values which are present in our > current static build configuration but are not normally meant for > user-configuration. Ideally, over time, the values placed here should be > moved to the individual libraries or drivers which want those values. >=20 > Signed-off-by: Bruce Richardson Comments inline below; > diff --git a/config/meson.build b/config/meson.build > +# disable any unwanted warnings > +unwanted_warnings =3D [ > + '-Wno-address-of-packed-member', > + '-Wno-format-truncation' > +] > +foreach arg: unwanted_warnings > + if cc.has_argument(arg) > + add_project_arguments(arg, language: 'c') > + endif > +endforeach I can't fault the code here, or Meson, just noting that the disabling of th= ese warnings causes prints on GCC 4.8.5 and GCC 5.4.0, GCC 7 only prints on= -Wno-address-of-packed-member. Clang handles it correctly - and no out-of-= the-ordinary prints occur. No code changes required here. > diff --git a/config/rte_config.h b/config/rte_config.h > new file mode 100644 > index 000000000..79b0db90f > --- /dev/null > +++ b/config/rte_config.h > @@ -0,0 +1,50 @@ > +/* > + * BSD LICENSE > + * > + * Copyright(c) 2016 Intel Corporation. All rights reserved. > + * All rights reserved. 2017 for license year Reviewed-by: Harry van Haaren