From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B4E277CA9 for ; Mon, 4 Sep 2017 16:25:01 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 07:25:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="147947564" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga006.fm.intel.com with ESMTP; 04 Sep 2017 07:25:00 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by IRSMSX152.ger.corp.intel.com ([169.254.6.87]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 15:24:59 +0100 From: "Van Haaren, Harry" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 05/17] build: add buildtools to meson build Thread-Index: AQHTIwvE/St7YnNLjk+AhuUBPYrMjKKkyNPA Date: Mon, 4 Sep 2017 14:24:59 +0000 Message-ID: References: <20170901100416.80264-1-bruce.richardson@intel.com> <20170901100416.80264-6-bruce.richardson@intel.com> In-Reply-To: <20170901100416.80264-6-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODgyMjdjNzItNGU3Mi00NTE4LWJiYmMtOGM5ODMxYjM5YzA1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJhc0lWQ3Y4SEZVZFJRTEJ6YzU2M09FemV5S1gyOVNYYVVJQnh5aEVsZTg9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 05/17] build: add buildtools to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 14:25:02 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, September 1, 2017 11:04 AM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 05/17] build: add buildtools to meson build >=20 > Add the buildtools folder, and more specifically the pmdinfogen binary to > the meson and ninja build. This will be needed for building the PMDs in t= he > driver folder later, as the pmd info output from the tool needs to be > included in those libs. >=20 > Signed-off-by: Bruce Richardson > +error_cflags =3D ['-Wno-maybe-uninitialized'] > +cflags =3D [] > +foreach arg: error_cflags > + if cc.has_argument(arg) > + cflags +=3D arg > + endif > +endforeach Removing the '-Wno-maybe-uninitialized' still compiles fine here with Clang= . GCC prints a warning... this could probably be fixed in "pmdinfogen.c" in f= uture, but this should not be done in the build-next branch, but patched in mainli= ne and then updated in the meson build. > + > +pmdinfogen =3D executable('pmdinfogen', > + 'pmdinfogen.c', > + include_directories: eal_inc, > + c_args: cflags) > diff --git a/meson.build b/meson.build > index f0e5741e3..d95321022 100644 > --- a/meson.build > +++ b/meson.build > @@ -59,6 +59,7 @@ subdir('config') >=20 > # build libs and (TODO) drivers > subdir('lib') > +subdir('buildtools') >=20 > # TODO build binaries and installable tools >=20 > -- > 2.13.5 Reviewed-by: Harry van Haaren