From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CA251101B for ; Wed, 6 Sep 2017 10:53:32 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2017 01:53:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,483,1498546800"; d="scan'208";a="308476141" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga004.fm.intel.com with ESMTP; 06 Sep 2017 01:53:30 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by irsmsx105.ger.corp.intel.com ([169.254.7.75]) with mapi id 14.03.0319.002; Wed, 6 Sep 2017 09:53:30 +0100 From: "Van Haaren, Harry" To: Guduri Prathyusha CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] service: fix service lcore stop function Thread-Index: AQHTJuAInZuip9vYCUeAw4o1tPveUqKnjMtQ Date: Wed, 6 Sep 2017 08:53:30 +0000 Message-ID: References: <20170906071541.1922-1-gprathyusha@caviumnetworks.com> In-Reply-To: <20170906071541.1922-1-gprathyusha@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M1NTBhODktZGJmYi00YmRlLTk1YjYtMDhmOTJmNDdkY2JlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1BNzE2XC9RbWlQQ3ZvZ2w4VXM3eGVCVXQ3anI3VHhJaWMyRU5hVzhzQ1FRPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 08:53:33 -0000 > From: Guduri Prathyusha [mailto:gprathyusha@caviumnetworks.com] > Sent: Wednesday, September 6, 2017 8:16 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Guduri Prathyusha > Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function >=20 > lcore_states store the state of the lcore. Fixing the invalid > dereference of lcore_states with service number >=20 > Unit test case service_lcore_start_stop fails with the above fix. > Service core was stopped without stopping the service. >=20 > This commit fixes the test by adding negative and positive cases of > stopping the service lcore before and after stopping the service > respectively >=20 > Fixes: 21698354c832 ("service: introduce service cores concept") > Fixes: f038a81e1c56 ("service: add unit tests") >=20 > Signed-off-by: Guduri Prathyusha Thanks for fixing and rebase / update to v2. Please mark the v1 of this pat= chset as "Superseded" in patchwork. Reviewed-by: Harry van Haaren > This patch is based on [1] To be totally clear, this patch depends on the service cores (v2) patchset, as linked at [1]. > v2 changes: > - Combined Patch 1/2 and 2/2 of v1 > - Rebased to the future service core patches [1] >=20 > [1] http://dpdk.org/dev/patchwork/patch/27684/