From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5A61EFFA for ; Wed, 6 Sep 2017 11:25:41 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 06 Sep 2017 02:25:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,483,1498546800"; d="scan'208";a="148049320" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga005.fm.intel.com with ESMTP; 06 Sep 2017 02:25:39 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 6 Sep 2017 10:25:35 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.59]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Wed, 6 Sep 2017 10:25:35 +0100 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] timer: fix reset on service cores Thread-Index: AQHTHCM+4ScvEZHJoEOnwKYBOkgaQqKnqfmQ Date: Wed, 6 Sep 2017 09:25:34 +0000 Message-ID: References: <1503501537-12383-1-git-send-email-pbhagavatula@caviumnetworks.com> In-Reply-To: <1503501537-12383-1-git-send-email-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzYxOGUyZDUtYzA3OS00OWUwLThmN2MtOThlNmI4ZjI4MmI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InRCeHdJMElvY3FVd1wvVkZXbGtZN3Q0V0RoUkNuclVoQk9PRW5uK2lFZVNJPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] timer: fix reset on service cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 09:25:41 -0000 > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Wednesday, August 23, 2017 4:19 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH] timer: fix reset on service cores >=20 > - API rte_timer_reset() should be able to register timers on service > lcores as they are EAL threads. Nitpick comment: remove - at the start. (I'd ignore this, but v2 required b= ased on below anyway..) > Fixes: af75078fece3 ("first public release") I'm not sure this is a fix to the first release.. service cores has only be= en added recently, I feel bad "git blaming" the first release :) I suggest renaming the title to "timer: allow timer reset on service cores"= , and removing the Fixes: tag. >=20 > Signed-off-by: Pavan Nikhilesh With above changes, Acked-by: Harry van Haaren > --- > This patch depends on http://dpdk.org/dev/patchwork/patch/27818/ > lib/librte_timer/rte_timer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c > index 5ee0840..a5a045c 100644 > --- a/lib/librte_timer/rte_timer.c > +++ b/lib/librte_timer/rte_timer.c > @@ -432,7 +432,8 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks= , > uint64_t period; >=20 > if (unlikely((tim_lcore !=3D (unsigned)LCORE_ID_ANY) && > - !rte_lcore_is_enabled(tim_lcore))) > + !(rte_lcore_is_enabled(tim_lcore) || > + rte_lcore_is_service_lcore(tim_lcore)))) > return -1; >=20 > if (type =3D=3D PERIODICAL) > -- > 2.7.4