From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B08C81B19F for ; Mon, 18 Sep 2017 17:40:12 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 08:40:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1173334073" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga001.jf.intel.com with ESMTP; 18 Sep 2017 08:40:10 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by IRSMSX108.ger.corp.intel.com ([169.254.11.167]) with mapi id 14.03.0319.002; Mon, 18 Sep 2017 16:40:09 +0100 From: "Van Haaren, Harry" To: "Rao, Nikhil" , "jerin.jacob@caviumnetworks.com" , "Richardson, Bruce" CC: "Eads, Gage" , "dev@dpdk.org" , "thomas@monjalon.net" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" Thread-Topic: [PATCH v3 4/4] eventdev: Add tests for event eth Rx adapter APIs Thread-Index: AQHTK3qr+HJxm4LhFkah/bbXNAC6dqK60Pow Date: Mon, 18 Sep 2017 15:40:08 +0000 Message-ID: References: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com> <1505219369-2493-5-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1505219369-2493-5-git-send-email-nikhil.rao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWU5YjkzMDEtYzY5Yi00ZjRlLWIxYmItNTk4Zjk0ZWY4ZWRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdPOWpJc05QQzNmd0VvOWQ5Wit2NlpMNnhrYzVHRTl1VnFlRGJ1amJnYnc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] eventdev: Add tests for event eth Rx adapter APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 15:40:13 -0000 > From: Rao, Nikhil > Sent: Tuesday, September 12, 2017 1:29 PM > To: jerin.jacob@caviumnetworks.com; Richardson, Bruce > > Cc: Eads, Gage ; dev@dpdk.org; thomas@monjalon.net; = Van > Haaren, Harry ; hemant.agrawal@nxp.com; > nipun.gupta@nxp.com; Vangati, Narender ; Carr= illo, > Erik G ; Gujjar, Abhinandan S > ; Rao, Nikhil > Subject: [PATCH v3 4/4] eventdev: Add tests for event eth Rx adapter APIs >=20 > Add unit tests for rte_event_eth_rx_adapter_xxx() APIs >=20 > Signed-off-by: Nikhil Rao > +static int > +init_ports(int num_ports) > +{ > + uint8_t portid; > + > + mp =3D rte_pktmbuf_pool_create("packet_pool", > + /* mbufs */ 8192 * num_ports * MAX_NUM_RX_QUEUE, > + /* cache_size */ 512, > + /* priv_size*/ 0, > + /* data_room_size */ RTE_MBUF_DEFAULT_BUF_SIZE, > + rte_socket_id()); A failure in allocating "mp" here will cause a segfault on the port_init() = call. Adding a little failure case works, but note that "0" tests execute if the init() of a test-suite fails: if(!mp) return -1; Allocating more hugepages passes this point. That's all for now, -Harry