From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1654C1B1B8 for ; Thu, 19 Oct 2017 13:06:42 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Oct 2017 04:06:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,401,1503385200"; d="scan'208";a="1232618947" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga002.fm.intel.com with ESMTP; 19 Oct 2017 04:06:38 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx105.ger.corp.intel.com ([163.33.3.28]) with mapi id 14.03.0319.002; Thu, 19 Oct 2017 12:06:38 +0100 From: "Van Haaren, Harry" To: "Yigit, Ferruh" , Ivan Malov , "thomas@monjalon.net" CC: "dev@dpdk.org" , "Kozak, KubaX" , "Daly, Lee" Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API Thread-Index: AQHTSFsGhXFFSK52+0ypQq9yex5af6LrAoWg Date: Thu, 19 Oct 2017 11:06:37 +0000 Message-ID: References: <20171018111019.GA5352@oktetlabs.ru> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTc1MTlmODItMjgwYi00MGJkLWFhMTktZTg0YWM0NWRlZDQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkgrVXg3bm1Cam1hVGZJTFVjUHhrTURreTJVa0NlK0pPWGZUNEZvQVdPZTg9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 11:06:43 -0000 PiBGcm9tOiBkZXYgW21haWx0bzpkZXYtYm91bmNlc0BkcGRrLm9yZ10gT24gQmVoYWxmIE9mIEZl cnJ1aCBZaWdpdA0KPiBTZW50OiBXZWRuZXNkYXksIE9jdG9iZXIgMTgsIDIwMTcgMTA6NDkgUE0N Cj4gVG86IEl2YW4gTWFsb3YgPEl2YW4uTWFsb3ZAb2t0ZXRsYWJzLnJ1PjsgRGFseSwgTGVlIDxs ZWUuZGFseUBpbnRlbC5jb20+Ow0KPiB0aG9tYXNAbW9uamFsb24ubmV0DQo+IENjOiBkZXZAZHBk ay5vcmc7IEtvemFrLCBLdWJhWCA8a3ViYXgua296YWtAaW50ZWwuY29tPg0KPiBTdWJqZWN0OiBS ZTogW2RwZGstZGV2XSBbUEFUQ0ggdjJdIGV0aGRldjogZml4IHhzdGF0cyByZXRyaWV2ZSBieSBp ZCBBUEkNCj4gDQo+IE9uIDEwLzE4LzIwMTcgNDoxMCBBTSwgSXZhbiBNYWxvdiB3cm90ZToNCj4g PiBPbiAxMC8xMi8yMDE3IDI6MzEgUE0sIExlZSBEYWx5IHdyb3RlOg0KPiA+PiBGcm9tOiBMZWUg PGxlZS5kYWx5QGludGVsLmNvbT4NCj4gPj4NCj4gPj4gRml4IHhzdGF0cyBmdW5jdGlvbnMsIHJ0 ZV9ldGhfeHN0YXRzX2dldF9uYW1lc19ieV9pZCgpDQo+ID4+IGFuZCBydGVfZXRoX3hzdGF0c19n ZXRfYnlfaWQoKSwgaW4gY3VycmVudCBpbXBsZW1lbnRhdGlvbg0KPiA+PiBldGhkZXYgbGV2ZWwg cmVhZHMgYWxsIHhzdGF0IHZhbHVlcyBhbmQgZmlsdGVycyBvdXQNCj4gPj4gdGhlIG9uZXMgcmVx dWVzdGVkIGJ5IHRoZSBhcHBsaWNhdGlvbi4gVGhpcyBiZWhhdmlvciBkb2Vzbid0DQo+ID4+IGJl bmVmaXQgZnJvbSBQTUQgb3BzIGFuZCBkb2Vzbid0IHByb3ZpZGUgdGhlIGJlbmVmaXQgdGhlDQo+ ID4+IEFQSSB3YXMgY3JlYXRlZCBpbiB0aGUgZmlyc3QgcGxhY2UgZm9yLiBBUElzIGFyZSBhbHNv IHVubmVjZXNzYXJpbHkNCj4gPj4gY29tcGxpY2F0ZWQuIEJvdGggQVBJcyBoYXZlIGRpZmZlcmVu dCByZXR1cm5zIGZvciB0aGUgc2FtZSBwYXJhbXMuDQo+ID4+DQo+ID4+IEluIHRoaXMgZml4LCBp bnN0ZWFkIG9mIHJlYWRpbmcgYWxsIHRoZSBzdGF0cyBhbmQgZmluZGluZyB0aGUNCj4gPj4gcmVx dWVzdGVkIHZhbHVlLCBkcml2ZXJzIGNhbiBwcm92aWRlIG9wcyB0byBnZXQgc2VsZWN0ZWQgeHN0 YXRzLg0KPiA+PiBBUEkgbm8gbG9uZ2VyIGNyYXNoZXMgd2l0aCBjZXJ0YWluIHBhcmFtcywNCj4g Pj4NCj4gPj4gcnRlX2V0aF9nZXRfYnlfaWQgcmV0dXJuZWQgc2VnIGZhdWx0IHdpdGgNCj4gPj4g ImlkcyA9IE5VTEwgJiYgdmFsdWVzICE9IE5VTEwgJiYgbjxtYXgiDQo+ID4+IHJ0ZV9ldGhfZ2V0 X25hbWVzX2J5X2lkIHJldHVybmVkIHNlZyBmYXVsdCB3aXRoDQo+ID4+ICJpZHMgPSBOVUxMICYm IHZhbHVlcyAhPSBOVUxMICYmIG49MCINCj4gPj4gVGhlc2Ugbm93IHJldHVybiBtYXggbnVtYmVy IG9mIHN0YXRzIGF2YWlsYWJsZSwgbWF0Y2hpbmcgdGhlIG90aGVyIEFQSS4NCj4gPj4NCj4gPj4g cnRlX2V0aF9nZXRfYnlfaWQgcmV0dXJuZWQgc2VnIGZhdWx0IHdpdGgNCj4gPj4gImlkcyAhPSBO VUxMICYmIHZhbHVlcyA9IE5VTEwgJiYgbjxtYXgiDQo+ID4+IFRoaXMgbm93IHJldHVybnMgLTIy LChFSU5WQUwpLg0KPiA+Pg0KPiA+PiBTdGFuZGFyZGl6ZWQgdmFyaWFibGUvcGFyYW1ldGVyIG5h bWVzIGJldHdlZW4gdGhlIDIgQVBJcy4NCj4gPj4NCj4gPj4gT3ZlcmFsbCBjb2RlIGNvbXBsZXhp dHkgcmVkdWNlZC4NCj4gPj4NCj4gPj4gRml4ZXM6IDc5YzkxM2E0MmYwZSAoImV0aGRldjogcmV0 cmlldmUgeHN0YXRzIGJ5IElEIikNCj4gPj4gQ2M6IGt1YmF4LmtvemFrQGludGVsLmNvbQ0KPiA+ Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBMZWUgRGFseSA8bGVlLmRhbHlAaW50ZWwuY29tPg0KPiA+ PiBSZXZpZXdlZC1ieTogRmVycnVoIFlpZ2l0IDxmZXJydWgueWlnaXRAaW50ZWwuY29tPg0KPiA+ DQo+ID4gSSBoYXZlIGEgc2VyaW91cyBjb25jZXJuIHJlZ2FyZGluZyB0aGUgcGF0Y2guIFRoZXJl IGlzIGEgY29tbW9uIHNjZW5hcmlvDQo+ID4gb2YgcnRlX2V0aF94c3RhdHNfZ2V0X25hbWVzX2J5 X2lkKCkgdXNhZ2UsIGFuZCB0aGUgcGF0Y2ggYnJlYWtzIGl0Lg0KPiA+IFR5cGljYWxseSwgdGhl IGZ1bmN0aW9uIGlzIGNhbGxlZCB3aXRoICdpZHMgPSBOVUxMJyBhbmQgJ3hzdGF0c19uYW1lcyA9 DQo+IE5VTEwnDQo+ID4gaW4gb3JkZXIgdG8gZ2V0IHRoZSBudW1iZXIgb2YgZmlndXJlcy4gVGhl biB0aGUgZnVuY3Rpb24gaXMgY2FsbGVkIG9uZQ0KPiBtb3JlDQo+ID4gdGltZSB3aXRoIGFwcHJv cHJpYXRlIHN0b3JhZ2UgZm9yICd4c3RhdHNfbmFtZXMnLiBBY2NvcmRpbmcgdG8gdGhlIHBhdGNo LA0KPiA+IG9uIHRoZSBmb3JtZXIgc3RlcCBnZXRfeHN0YXRzX2NvdW50KCkgaXMgY2FsbGVkIHRv IGNvdW50IHRoZSBmaWd1cmVzDQo+IGF2YWlsYWJsZS4NCj4gPiBUaGUgcmVzdWx0aW5nIG51bWJl ciBjb3VudHMgZm9yIFBNRCBzdGF0aXN0aWNzICsgUlRFX05CX1NUQVRTICsgc29tZQ0KPiBhbW91 bnQgb2YNCj4gPiBwZXItcXVldWUgZmlndXJlcy4gSG93ZXZlciwgb24gdGhlIGxhdHRlciBzdGVw IHRoZSBmb2xsb3dpbmcgbWF5IHRha2UNCj4gcGxhY2U6DQo+ID4NCj4gPj4gKwlpZiAoZGV2LT5k ZXZfb3BzLT54c3RhdHNfZ2V0X25hbWVzX2J5X2lkICE9IE5VTEwpDQo+ID4+ICsJCXJldHVybiAo KmRldi0+ZGV2X29wcy0+eHN0YXRzX2dldF9uYW1lc19ieV9pZCkoDQo+ID4+ICsJCQkJZGV2LCB4 c3RhdHNfbmFtZXMsIGlkcywgc2l6ZSk7DQo+ID4NCj4gPiBUaGlzIG9idmlvdXNseSBtZWFucyB0 aGF0IGluIHRoZSBjYXNlIHdoZW4gJ3hzdGF0c19nZXRfbmFtZXNfYnlfaWQnIGlzDQo+IHByZXNl bnQsDQo+ID4gaXQgd2lsbCBiZSBjYWxsZWQgZGlyZWN0bHksIGFuZCBSVEUgc3RhdGlzdGljcyB3 aWxsIG5vdCBiZSBmaWxsZWQgaW4gdGhlDQo+IHN0b3JhZ2UNCj4gPiBiZWZvcmUgdGhlIFBNRCBm aWd1cmVzLiBBY2NvcmRpbmdseSwgdGhlIHZhbHVlIHJldHVybmVkIGJ5IHRoZSBmdW5jdGlvbiBp bg0KPiB0aGlzDQo+ID4gY2FzZSB3aWxsIGNvdW50IGZvciBQTUQgZmlndXJlcyBvbmx5IChpLmUu IHdpbGwgYmUgbGVzcyB0aGFuIHRoZSB2YWx1ZQ0KPiBvYnRhaW5lZA0KPiA+IG9uIHRoZSBmaXJz dCBzdGVwKS4gVGhpcyBpcyBhbiBvYnZpb3VzIG1hbGZ1bmN0aW9uLCBhbmQgaXQgd291bGQgYmUN Cj4gZGVzaXJhYmxlDQo+ID4gdG8gcHJvdmlkZSBhIGZpeCBmb3IgdGhhdC4gSSBob3BlIGZvciB5 b3VyIHVuZGVyc3RhbmRpbmcuDQo+IA0KPiBIaSBJdmFuLA0KPiANCj4gWW91IGFyZSByaWdodCwg dGhpcyBpcyBicm9rZW4uDQo+IA0KPiBCdXQgdGhlIHByb2JsZW0gaXMsIGV0aGRldiBBUEkgd29y a3Mgd2l0aCBpZHMgd2hpY2ggYXJlICJiYXNpYyArIHhzdGF0IiBhbmQNCj4gUE1EIGRldl9vcHMN Cj4gd29ya3Mgd2l0aCBpZHMgd2hpY2ggYXJlICJ4c3RhdCIuIFRoaXMgbWlzbWF0Y2ggZW5kcyB1 cA0KPiB4c3RhdHNfZ2V0X25hbWVzX2J5X2lkKCkgZGV2X29wcw0KPiBiZWluZyBjYWxsZWQgdG8g Z2V0IGFsbCB2YWx1ZXMsIGFuZCBmaWx0ZXJpbmcgZG9uZSBpbiBldGhkZXYgQVBJLCBhcyBkb25l IGluDQo+IHByZXZpb3VzDQo+IGltcGxlbWVudGF0aW9uLg0KPiANCj4gSWYgd2UgdXNlIHhzdGF0 c19nZXRfbmFtZXNfYnlfaWQoKSB0byBnZXQgYWxsIHZhbHVlcywgd2h5IHdlIGhhdmUgaXQgYXQg YWxsLA0KPiB0aGVyZSBpcw0KPiBhbHJlYWR5IGEgZGV2X29wcyB0byBnZXQgYWxsIHZhbHVlcy4N Cj4gDQo+IEkgYmVsaWV2ZSB3ZSBoYXZlIHR3byBvcHRpb25zLA0KPiANCj4gMS0gUmVtb3ZlIHRo aXMgYnkgX2J5X2lkKCkgZGV2X29wcywgYnV0IGtlZXAgZXRoZGV2IEFQSXMsIGFuZCBBUElzIGRv ZXMgdGhlDQo+IGZpbHRlcmluZyBvZg0KPiB0aGUgaWRzLiBUaGlzIG1heSBiZSBtaXNzaW5nIGlm IGFueSBQTUQgaGFzIGFuIG9wdGltYWwgd2F5IG9mIGdldHRpbmcgc3Vic2V0DQo+IG9mIGlkcywg dGhpcw0KPiBpcyB0aGUgbWFpbiByZWFzb24gb2YgdGhlIGRldm9wcy4NCg0KDQpMZXRzIG5vdCBy ZW1vdmUgdGhlIF9ieV9pZCgpIG9wdHMsIGJlY2F1c2UgdGhhdCByZW1vdmVzIHRoZSBwb3NzaWJp bGl0eSBmb3IgUE1EcyB0byBvcHRpbWl6ZSB0aGUgZ2V0X2J5X2lkKCkgY2FzZS4NCg0KDQo+IDIt IENvbnZlcnQgaWRzIGZvciBQTUQgdXNhZ2UsIHdoYXQgZG8geW91IHRoaW5rIGFib3V0IGZvbGxv d2luZyBmaXg6DQo+IChzYW1lIHRoaW5nIGZvciBydGVfZXRoX3hzdGF0c19nZXRfYnlfaWQoKSBh bHNvIG9mIGNvdXJzZSkNCg0KDQpBIHF1aWNrIHRlc3Qgb2YgdGhpcyBwYXRjaCBhbGxvd3MgcHJv Yy1pbmZvIHRvIHdvcmsgYWdhaW4gdG8gZHVtcCB4c3RhdHMgb2YgYSBwcmltYXJ5LCBlZyB0ZXN0 cG1kLiBSdW4gdGVzdHBtZCBmaXJzdCBhbmQgdGhlbiBwcm9jLWluZm86DQoNCnRlc3RwbWQ6IC4v dGVzdHBtZCAtLSAtaQ0KcHJvYy1pbmZvOiAuL2RwZGstcHJvY2luZm8gIC0tIC0teHN0YXRzDQoN CkJlZm9yZSBwYXRjaDoNCkNhbm5vdCBnZXQgeHN0YXQgbmFtZXMNCkNhbm5vdCBnZXQgeHN0YXQg bmFtZXMNCg0KQWZ0ZXIgcGF0Y2g6DQo8Y29ycmVjdCB4c3RhdHMgb3V0cHV0Pg0KDQpJIHN1Z2dl c3Qgd2UgdXNlIEZlcnJ1aCdzIGZpeCwgYW5kIGFwcGx5IEFTQVAgdW5sZXNzIEBJdmFuIGhhcyBh IGJldHRlciBzb2x1dGlvbi9zdWdnZXN0aW9uPw0KDQoNCg0KPiAgIGRpZmYgLS1naXQgYS9saWIv bGlicnRlX2V0aGVyL3J0ZV9ldGhkZXYuYyBiL2xpYi9saWJydGVfZXRoZXIvcnRlX2V0aGRldi5j DQo+ICAgaW5kZXggMGIxZTkyODk0Li4xMTQ1NTM5ZWUgMTAwNjQ0DQo+ICAgLS0tIGEvbGliL2xp YnJ0ZV9ldGhlci9ydGVfZXRoZGV2LmMNCj4gICArKysgYi9saWIvbGlicnRlX2V0aGVyL3J0ZV9l dGhkZXYuYw0KPiAgIEBAIC0xNjMxLDYgKzE2MzEsNyBAQCBydGVfZXRoX3hzdGF0c19nZXRfbmFt ZXNfYnlfaWQodWludDE2X3QgcG9ydF9pZCwNCj4gICAgew0KPiAgICAgICAgICAgc3RydWN0IHJ0 ZV9ldGhfeHN0YXRfbmFtZSAqeHN0YXRzX25hbWVzX2NvcHk7DQo+ICAgICAgICAgICB1bnNpZ25l ZCBpbnQgZXhwZWN0ZWRfZW50cmllczsNCj4gICArICAgICAgIHVuc2lnbmVkIGludCBhbGxfaWRz X2Zyb21fcG1kID0gMTsNCj4gICAgICAgICAgIHN0cnVjdCBydGVfZXRoX2RldiAqZGV2Ow0KPiAg ICAgICAgICAgdW5zaWduZWQgaW50IGk7DQo+IA0KPiAgIEBAIC0xNjQ5LDkgKzE2NTAsMjggQEAg cnRlX2V0aF94c3RhdHNfZ2V0X25hbWVzX2J5X2lkKHVpbnQxNl90IHBvcnRfaWQsDQo+ICAgICAg ICAgICBpZiAoaWRzICYmICF4c3RhdHNfbmFtZXMpDQo+ICAgICAgICAgICAgICAgICAgIHJldHVy biAtRUlOVkFMOw0KPiANCj4gICAtICAgICAgIGlmIChkZXYtPmRldl9vcHMtPnhzdGF0c19nZXRf bmFtZXNfYnlfaWQgIT0gTlVMTCkNCj4gICAtICAgICAgICAgICAgICAgcmV0dXJuICgqZGV2LT5k ZXZfb3BzLT54c3RhdHNfZ2V0X25hbWVzX2J5X2lkKSgNCj4gICAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRldiwgeHN0YXRzX25hbWVzLCBpZHMsIHNpemUpOw0KPiAgICsgICAgICAg aWYgKGlkcyAmJiBkZXYtPmRldl9vcHMtPnhzdGF0c19nZXRfbmFtZXNfYnlfaWQgIT0gTlVMTCAm JiBzaXplID4NCj4gMCkgew0KPiAgICsgICAgICAgICAgICAgICB1aW50NjRfdCBpZHNfY29weVtz aXplXTsNCj4gICArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHBtZF9jb3VudDsNCj4gICAr ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGNvdW50Ow0KPiAgICsNCj4gICArICAgICAgICAg ICAgICAgcG1kX2NvdW50ID0gKCpkZXYtPmRldl9vcHMtPnhzdGF0c19nZXRfbmFtZXNfYnlfaWQp KGRldiwNCj4gTlVMTCwNCj4gICArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgTlVMTCwgMCk7DQo+ICAgKyAgICAgICAgICAgICAgIGNvdW50ID0gZXhwZWN0ZWRfZW50cmll cyAtIHBtZF9jb3VudDsNCj4gICArDQo+ICAgKyAgICAgICAgICAgICAgIGZvciAoaSA9IDA7IGkg PCBzaXplOyBpKyspIHsNCj4gICArICAgICAgICAgICAgICAgICAgICAgICBpZiAoaWRzW2ldIDwg Y291bnQpIHsNCj4gICArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFsbF9pZHNfZnJv bV9wbWQgPSAwOw0KPiAgICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7DQo+ ICAgKyAgICAgICAgICAgICAgICAgICAgICAgfQ0KPiAgICsNCj4gICArICAgICAgICAgICAgICAg ICAgICAgICBpZHNfY29weVtpXSA9IGlkc1tpXSAtIGNvdW50Ow0KPiAgICsgICAgICAgICAgICAg ICB9DQo+ICAgKw0KPiAgICsgICAgICAgICAgICAgICBpZiAoYWxsX2lkc19mcm9tX3BtZCkNCj4g ICArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gKCpkZXYtPmRldl9vcHMtDQo+ID54c3Rh dHNfZ2V0X25hbWVzX2J5X2lkKShkZXYsDQo+ICAgKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHhzdGF0c19uYW1lcywgaWRzX2NvcHksIHNpemUpOw0KPiAgICsgICAgICAg fQ0KPiANCj4gICAgICAgICAgIC8qIFJldHJpZXZlIGFsbCBzdGF0cyAqLw0KPiAgICAgICAgICAg aWYgKCFpZHMpIHsNCg==