From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 500A3231E for ; Wed, 25 Oct 2017 11:09:56 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 25 Oct 2017 02:09:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,431,1503385200"; d="scan'208";a="142006763" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga004.jf.intel.com with ESMTP; 25 Oct 2017 02:09:55 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0319.002; Wed, 25 Oct 2017 10:09:54 +0100 From: "Van Haaren, Harry" To: Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/2] service: add runtime service core check disable Thread-Index: AQHTTCLEa+RLWeTvf0isCNoQog73BaLzMOkAgAEYBQA= Date: Wed, 25 Oct 2017 09:09:53 +0000 Message-ID: References: <1508779012-56186-1-git-send-email-harry.van.haaren@intel.com> <1508779012-56186-3-git-send-email-harry.van.haaren@intel.com> <20171024172439.GA18820@PBHAGAVATULA-LT> In-Reply-To: <20171024172439.GA18820@PBHAGAVATULA-LT> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzI2ZGMxODYtYmVhMC00YmJlLTljMDctZmIxY2RmMzdiZDczIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlM5WUlRUkhLRGUxQndzT3o1elhIZ3FYeUZXUWRxeUxIbGNvK0dwK0JhTjg9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] service: add runtime service core check disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 09:09:57 -0000 > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com= ] > Sent: Tuesday, October 24, 2017 6:25 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/2] service: add runtime service core check disable >=20 > On Mon, Oct 23, 2017 at 06:16:52PM +0100, Harry van Haaren wrote: > > This commit adds a new function to disable the runtime mapped > > service-cores check. This allows an application to take responsibility > > of running unmapped services. > > > > This feature is useful in cases like unit tests, where the application > > code (or unit test in this case) requires accurate control over when > > the service function is called to ensure correct behaviour, and when > > an application has an advanced use-case and wishes to manage services > > manually. > > >=20 > Hey Harry, >=20 > The patch looks good from a logical point of view, I have integrated this > with > 4/7 and 5/7 of the patch set [1] for removing eventdev schedule API and > everything > works well. >=20 > My only concern is that the function name is a bit tricky to grasp. Unles= s > the > application(dev) knows the internal working of rte_service_runstate_get()= it > would be a bit tricky to understand the role of > rte_service_set_runstate_mapped_check(). >=20 > I think we should think of a more appropriate API name for this function. Suggestions welcome! Otherwise I hope the documentation and unit-test usages explain the functio= nality ok. Cheers, -Harry > > Signed-off-by: Harry van Haaren > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/include/rte_service.h | 23 > ++++++++++++++++++++++- > > lib/librte_eal/common/rte_service.c | 22 > ++++++++++++++++++++-- > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 4 files changed, 44 insertions(+), 3 deletions(-) > > > + * @param enabled When zero, the check is disabled. Non-zero enables t= he > check. > > + * > > + * @retval 0 Success > > + * @retval -EINVAL Invalid service ID > > + */ > > +int32_t rte_service_set_runstate_mapped_check(uint32_t id, int32_t > enabled); > > + > s/enabled/enable > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > * This function runs a service callback from a non-service lcore > context. > > * The *id* of the service to be run is passed in, and the service- > callback > > * is executed on the calling lcore immediately if possible. If the > service is > > > > > -- > > 2.7.4 > > >=20 > Regards, > Pavan