From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id F1600E5D for ; Wed, 13 Dec 2017 11:19:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2017 02:19:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,397,1508828400"; d="scan'208";a="15609344" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 13 Dec 2017 02:19:53 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Dec 2017 10:19:52 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002; Wed, 13 Dec 2017 10:19:51 +0000 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "Richardson, Bruce" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver Thread-Index: AQHTc39TouyxAUlJ/062PtjSIr/2gKNBDLYw Date: Wed, 13 Dec 2017 10:19:51 +0000 Message-ID: References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> In-Reply-To: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTRkYWI5MWItZjQ3NS00NjA4LTgxMDAtMzdkYzczMTg1Mjg1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InhpeFUyaGhWbk5URUdQSTk4a1BWSEJBbFNoK1o2WVNJYWhWamhLTTUwMUU9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx test to driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 10:19:56 -0000 > -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Tuesday, December 12, 2017 7:27 PM > To: jerin.jacob@caviumnetworks.com; Richardson, Bruce > ; Van Haaren, Harry > ; Eads, Gage ; > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 1/7] event/octeontx: move eventdev octeontx te= st > to driver >=20 > Move octeontx eventdev specific test (test_eventdev_octeontx.c) to > driver/event/octeontx. Replying to 1st patch, as no cover letter; Summary of patchset: - Move tests for a specific Eventdev PMD into the PMD dir: drivers/event/x/= x_selftest.c - Enable self tests to run when passed the vdev arg "self-test=3D1" A few comments on this change; 1) We should not lose the capability to run tests as part of the existing u= nit testing infrastructure. We should not fragment the testing tool - requi= ring multiple binaries to test a single component. >>From discussion on #IRC, it seems reasonable to call rte_eal_vdev_init() = with "self-test=3D1" from the test/test/ code, and then we can continue to = use the existing test infrastructure despite that the actual tests are now = part of each PMD. 2) We should not copy/paste TEST_ASSERT macros into new test files. Abstrac= ting the TEST_ASSERT and other macros out to a header file would solve this= duplication. Specific comments will be sent as replies to the patches. Cheers, -Harry