From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 331501B01D for ; Wed, 20 Dec 2017 11:14:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2017 02:14:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,431,1508828400"; d="scan'208";a="188584566" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga006.fm.intel.com with ESMTP; 20 Dec 2017 02:14:40 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Wed, 20 Dec 2017 10:14:39 +0000 From: "Van Haaren, Harry" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] meson: add tests to build Thread-Index: AQHTeO9OO5ynr0qMkkaXhivTuR1ob6NMA9JA Date: Wed, 20 Dec 2017 10:14:39 +0000 Message-ID: References: <20171219173131.25125-1-kevin.laatz@intel.com> In-Reply-To: <20171219173131.25125-1-kevin.laatz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2UyZjBmOGMtODU0YS00NDYwLTg1MDgtYzU5NzNiNTQyMGQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik1GaEt5eWErYytPU3V0WUVra1kxSlJpOE41VDdPdHFHOFZqTDJRZEw5YVk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] meson: add tests to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 10:14:43 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kevin Laatz > Sent: Tuesday, December 19, 2017 5:32 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Laatz, Kevin > > Subject: [dpdk-dev] [PATCH] meson: add tests to build >=20 > This commit adds most of the remaining tests to the meson build. > They can be run using test binary as normal. Cool, thanks for adding more tests! > Signed-off-by: Kevin Laatz > --- > test/test/meson.build | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/test/test/meson.build b/test/test/meson.build > index 1a4f894..a9bc2f6 100644 > --- a/test/test/meson.build > +++ b/test/test/meson.build > @@ -47,6 +47,8 @@ test_sources =3D files('commands.c', > 'test_common.c', > 'test_cpuflags.c', > 'test_crc.c', > + 'test_cryptodev.c', > + 'test_cryptodev_blockcipher.c', Each of the test files here exports a number of actual test cases, eg: RTE>> cryptodev_null_autotest and similar. These test cases should be added to the list called "test_names" in the same file - so Meson knows about the tests. There was talk of refactoring away this list totally - and that would be good - but for now we're best to keep it in sync with the available tests. Apart from the above, the patch looks good to me! Will Review/Ack a v2.