From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] test/test: fix missed failures when running meson test
Date: Thu, 21 Dec 2017 10:44:41 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA650FE4B54@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20171221101510.181082-2-bruce.richardson@intel.com>
> From: Richardson, Bruce
> Sent: Thursday, December 21, 2017 10:15 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: [PATCH 1/2] test/test: fix missed failures when running meson test
>
> When using meson test, and/or the DPDK_TEST environment variable for
> running specific tests, the return value from the test binary was the value
> returned from the unit test runner function. However, not all tests use
> that unit test runner infrastructure - some are regular functions, and so
> the failure of those tests would not be recognised.
>
> Fix this by setting the last_test_result value inside the command-line
> function that calls the individual test fns and that prints the "Test OK"
> or "Test Failure" messages.
>
> Fixes: d79a9657a78c ("meson: add tests app to build")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2017-12-21 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 10:15 [dpdk-dev] [PATCH 0/2] improve meson test support Bruce Richardson
2017-12-21 10:15 ` [dpdk-dev] [PATCH 1/2] test/test: fix missed failures when running meson test Bruce Richardson
2017-12-21 10:44 ` Van Haaren, Harry [this message]
2017-12-21 10:15 ` [dpdk-dev] [PATCH 2/2] test/test: add return value to mark unit tests as skipped Bruce Richardson
2017-12-21 10:22 ` Bruce Richardson
2017-12-21 10:48 ` Van Haaren, Harry
2017-12-21 12:21 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA650FE4B54@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).