From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EC74A1B1B9 for ; Thu, 21 Dec 2017 11:44:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 02:44:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,435,1508828400"; d="scan'208";a="160681355" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 21 Dec 2017 02:44:41 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0319.002; Thu, 21 Dec 2017 10:44:41 +0000 From: "Van Haaren, Harry" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [PATCH 1/2] test/test: fix missed failures when running meson test Thread-Index: AQHTekSsvmuRw8rc10W1xQdh+Ue8naNNnKCA Date: Thu, 21 Dec 2017 10:44:41 +0000 Message-ID: References: <20171221101510.181082-1-bruce.richardson@intel.com> <20171221101510.181082-2-bruce.richardson@intel.com> In-Reply-To: <20171221101510.181082-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjI3ZWRhYTctZGJlYi00OTRiLWFhNDItMzUyNzFlNzU4MDUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRPUGk4UE5cL0M4bGFWQ3JOc0dtN04rSnk3eEorUUY5dVJ6Zjc1eUFhQUljPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] test/test: fix missed failures when running meson test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 10:44:44 -0000 > From: Richardson, Bruce > Sent: Thursday, December 21, 2017 10:15 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Richardson, Bruce > > Subject: [PATCH 1/2] test/test: fix missed failures when running meson te= st >=20 > When using meson test, and/or the DPDK_TEST environment variable for > running specific tests, the return value from the test binary was the val= ue > returned from the unit test runner function. However, not all tests use > that unit test runner infrastructure - some are regular functions, and so > the failure of those tests would not be recognised. >=20 > Fix this by setting the last_test_result value inside the command-line > function that calls the individual test fns and that prints the "Test OK" > or "Test Failure" messages. >=20 > Fixes: d79a9657a78c ("meson: add tests app to build") >=20 > Signed-off-by: Bruce Richardson Reviewed-by: Harry van Haaren