From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BF4D31B1CE for ; Wed, 10 Jan 2018 17:38:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 08:38:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,341,1511856000"; d="scan'208";a="10198092" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga006.jf.intel.com with ESMTP; 10 Jan 2018 08:38:36 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX106.ger.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 16:38:35 +0000 From: "Van Haaren, Harry" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 08/12] app/eventdev: add pipeline queue test Thread-Index: AQHTiiK4h9wSdbpOqUCx+S46GEP66aNtTFFg Date: Wed, 10 Jan 2018 16:38:35 +0000 Message-ID: References: <20171130072406.15605-1-pbhagavatula@caviumnetworks.com> <20180110145144.28403-1-pbhagavatula@caviumnetworks.com> <20180110145144.28403-8-pbhagavatula@caviumnetworks.com> In-Reply-To: <20180110145144.28403-8-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzYyNDUxZGItZDgxNy00MWE4LWJmY2ItYmFkOWJjZGIxYWE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdHUFBFcVZyT2hLbFQyeWxPdE5DdDJjcVp3UEJ5UFFDRWx1aEFXU2xBUms9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 08/12] app/eventdev: add pipeline queue test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 16:38:41 -0000 > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Wednesday, January 10, 2018 2:52 PM > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; Va= n > Haaren, Harry ; Eads, Gage > ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, > Liang J > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 08/12] app/eventdev: add pipeline queue tes= t >=20 > This is a pipeline queue test case that aims at testing the following: > 1. Measure the end-to-end performance of an event dev with a ethernet dev= . > 2. Maintain packet ordering from Rx to Tx. >=20 > The pipeline queue test configures the eventdev with Q queues and P ports= , > where Q is (nb_ethdev * nb_stages) + nb_ethdev and P is nb_workers. Why (nb_ethdev * nb_stages) number of Queues? I had expected if the test is for eventdev with Q queues, P ports, that tha= t Q number of stages is all that is required, (possibly with +1 for TX queu= e, iirc some HW doesn't require the TX Queue). Am I missing something here? I've left the code snippet I don't understand = below. > Note: The --prod_type_ethdev is mandatory for running the application. Mandatory arguments seem pointless to me, unless there are other valid opti= ons to choose from. > + > +static int > +pipeline_queue_eventdev_setup(struct evt_test *test, struct evt_options > *opt) > +{ > + int ret; > + int nb_ports; > + int nb_queues; > + int nb_stages =3D opt->nb_stages; > + uint8_t queue; > + struct rte_event_dev_info info; > + > + nb_ports =3D evt_nr_active_lcores(opt->wlcores); > + nb_queues =3D rte_eth_dev_count() * (nb_stages); As per comment above, this is what I don't understand? Why more queues than= stages?