From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ma, Liang J" <liang.j.ma@intel.com>,
"Mccarthy, Peter" <peter.mccarthy@intel.com>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] Dynamic Logging Name Formatting
Date: Wed, 24 Jan 2018 09:36:13 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA650FF4A82@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20180124092757.fucu6nncp3tx4tsv@glumotte.dev.6wind.com>
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Wednesday, January 24, 2018 9:28 AM
> To: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> dev@dpdk.org; Ma, Liang J <liang.j.ma@intel.com>; Mccarthy, Peter
> <peter.mccarthy@intel.com>; santosh.shukla@caviumnetworks.com;
> jerin.jacob@caviumnetworks.com
> Subject: Re: [dpdk-dev] Dynamic Logging Name Formatting
>
> On Wed, Jan 24, 2018 at 09:32:33AM +0300, Andrew Rybchenko wrote:
> > On 01/23/2018 11:54 PM, Bruce Richardson wrote:
> > > On Tue, Jan 23, 2018 at 05:45:09PM +0000, Ferruh Yigit wrote:
> > > > On 1/23/2018 5:31 PM, Van Haaren, Harry wrote:
> > > > > === Suggested Consistent Schema ===
> > > > > ===================================
> > > > >
> > > > > Libraries:
> > > > > lib.<name>.specialization
> > > > >
> > > > > Net PMDs:
> > > > > pmd.<name>.specialization
> > > > > // one could argue consistency would be pmd.ethdev.<name>
> > > > > // but the change is larger than the value IMO - thoughts?
> > > pmd.net ??
> > >
> > > > > Eventdev PMDs:
> > > > > pmd.eventdev.<name>.specialization
> > > > >
> > > > > Crypto PMDs:
> > > > > pmd.cryptodev.<name>.specialization
> > > > >
> > > "event" and "crypto" without the "dev" on the end, which would also
> > > match "net" above.
> >
> > I like the scheme suggested by Bruce including pmd.net. Shorter and
> > consistent.
>
> Agree.
Thanks for feedback all, I'll send a patch to rework the existing names into the scheme as converged on here, and document the naming scheme in the docs.
next prev parent reply other threads:[~2018-01-24 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 17:31 Van Haaren, Harry
2018-01-23 17:45 ` Ferruh Yigit
2018-01-23 20:54 ` Bruce Richardson
2018-01-24 6:32 ` Andrew Rybchenko
2018-01-24 9:27 ` Olivier Matz
2018-01-24 9:36 ` Van Haaren, Harry [this message]
2018-01-25 9:35 ` Shreyansh Jain
2018-01-25 9:28 ` Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA650FF4A82@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=liang.j.ma@intel.com \
--cc=olivier.matz@6wind.com \
--cc=peter.mccarthy@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).