From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1157F1B66D for ; Mon, 29 Jan 2018 12:10:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 03:10:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="30294625" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga002.jf.intel.com with ESMTP; 29 Jan 2018 03:10:45 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX109.ger.corp.intel.com (163.33.3.23) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 11:10:44 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by irsmsx111.ger.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Mon, 29 Jan 2018 11:10:45 +0000 From: "Van Haaren, Harry" To: Thomas Monjalon CC: "dev@dpdk.org" , "Varghese, Vipin" Thread-Topic: [PATCH v2 2/4] eal: add function to release internal resources Thread-Index: AQHTmO51zNxoE7Ze90Wo+W695Un+8qOKrZ8AgAADZYA= Date: Mon, 29 Jan 2018 11:10:44 +0000 Message-ID: References: <1517077877-53654-1-git-send-email-harry.van.haaren@intel.com> <1517222751-110376-1-git-send-email-harry.van.haaren@intel.com> <1517222751-110376-2-git-send-email-harry.van.haaren@intel.com> <3800883.jMHuFJQnlm@xps> In-Reply-To: <3800883.jMHuFJQnlm@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTFhZjFjMzYtYTRkYy00Zjg0LWI5NGItMTllZGU5OGYwZTRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJHQ291RkpcL3ZYN0VYb2x1QVBNN2ZTSnErcGpUKyszZ0pcL0JVZmhkYTc4clFuMEhmZ05tSGxwc1VFQVwvTkFiZFZqIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] eal: add function to release internal resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 11:10:49 -0000 > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, January 29, 2018 10:56 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Varghese, Vipin > Subject: Re: [PATCH v2 2/4] eal: add function to release internal resourc= es >=20 > 29/01/2018 11:45, Harry van Haaren: > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > +Finalizing and Cleanup > > +~~~~~~~~~~~~~~~~~~~~~~ > > + > > +During the initialization of EAL resources such as hugepage backed mem= ory > can be > > +allocated by core components. The memory allocated during > ``rte_eal_init()`` > > +can be released by calling the ``rte_eal_finalize()`` function. Refer = to > the > > +API documentation for details. >=20 > About naming, what is better between > rte_eal_finalize() and > rte_eal_cleanup() ? > I tend to think that "cleanup" is more descriptive. Sure cleanup() is fine for me, I'll spin a v3 with the function name change= .