From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9DCFF1B336 for ; Mon, 5 Feb 2018 13:26:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 04:26:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,464,1511856000"; d="scan'208";a="201273205" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga005.fm.intel.com with ESMTP; 05 Feb 2018 04:26:36 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX152.ger.corp.intel.com ([169.254.6.52]) with mapi id 14.03.0319.002; Mon, 5 Feb 2018 12:24:23 +0000 From: "Van Haaren, Harry" To: Marcelo Ricardo Leitner , Adrien Mazarguil CC: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , Nelio Laranjeiro Thread-Topic: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries Thread-Index: AQHTnnProhwegTHehkC4VEvZ+G2NNKOVuJqAgAABRtA= Date: Mon, 5 Feb 2018 12:24:23 +0000 Message-ID: References: <20180202144736.8239-1-adrien.mazarguil@6wind.com> <20180202164050.13017-1-adrien.mazarguil@6wind.com> <20180202164050.13017-4-adrien.mazarguil@6wind.com> <6047554.pbob4v6vxF@xps> <20180205112402.GE4256@6wind.com> <20180205121339.GB27676@localhost.localdomain> In-Reply-To: <20180205121339.GB27676@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2IxYmU4NmUtMDhhOC00Nzk5LTllZTAtMGZjNjhhOGY0ODc5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJoNXJpNG9VM2NwWmhMZ3RDRlpoa1BwYWRUM2NVZCtBbDVWUG9rTHhndDNBVFhqTjFHbEUxakJqSlwvQUpsN3V0byJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 12:26:42 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marcelo Ricardo Leit= ner > Sent: Monday, February 5, 2018 12:14 PM > To: Adrien Mazarguil > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf Shuler > ; Nelio Laranjeiro > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue > libraries >=20 > On Mon, Feb 05, 2018 at 12:24:02PM +0100, Adrien Mazarguil wrote: > > On Sun, Feb 04, 2018 at 03:29:38PM +0100, Thomas Monjalon wrote: > > > 02/02/2018 17:46, Adrien Mazarguil: > > > > --- a/drivers/net/mlx4/Makefile > > > > +++ b/drivers/net/mlx4/Makefile > > > > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk > > > > > > > > # Library name. > > > > LIB =3D librte_pmd_mlx4.a > > > > -LIB_GLUE =3D librte_pmd_mlx4_glue.so > > > > +LIB_GLUE =3D $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) > > > > +LIB_GLUE_BASE =3D librte_pmd_mlx4_glue.so > > > > +LIB_GLUE_VERSION =3D 18.02.1 > > > > > > You should use the version number of the release, i.e. 18.02.0 > > > Ideally, you should retrieve it from rte_version.h. > > > > Keep in mind this only needs to be updated when the glue API gets > modified, > > and this "18.02.1" string may remain unmodified for subsequent DPDK > > releases, probably as long as the PMD doesn't use any new rdma-core cal= ls. > > > > We've already backported this patch to 17.02 and 17.11, both requiring > > different sets of Verbs calls and thus a different version, hence the > added > > "18.02" as a starting point. The last digit may have to be modified > possibly > > several times between official DPDK releases while work is being done o= n > the > > PMD (i.e. per commit). > > > > In short it's not meant to follow DPDK's public versioning scheme. If y= ou > > really think it should, doing so will make things more complex in the > > Makefile, which will have to parse rte_version.h. What's your opinion? >=20 > What about appending date +%s output to it? It would be stricter and > automated. Adding current timestamp or date into a build breaks reproducibility of bui= lds, so is generally not recommended. No opinion on string/version naming here.