From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id F208B1B29F for ; Tue, 13 Feb 2018 15:16:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 06:16:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,507,1511856000"; d="scan'208";a="17377589" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga007.fm.intel.com with ESMTP; 13 Feb 2018 06:16:08 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.95]) by IRSMSX154.ger.corp.intel.com ([169.254.12.108]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 14:16:07 +0000 From: "Van Haaren, Harry" To: Thomas Monjalon , "Burakov, Anatoly" CC: "dev@dpdk.org" , "Tan, Jianfeng" Thread-Topic: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API Thread-Index: AQHTotUNo9Ae9yEyJ0Kirh4BHkUldaOiXagAgAAECtA= Date: Tue, 13 Feb 2018 14:16:08 +0000 Message-ID: References: <46a01b34318bbc799a0911fbb166a592c34ffa66.1518267551.git.anatoly.burakov@intel.com> <7815253.RbYmxIpbrz@xps> In-Reply-To: <7815253.RbYmxIpbrz@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzdjYThkYWUtYzAwOC00NTUyLTgwYWUtZWU4ZWY0MmYwMTY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJCa1RjMkZ5RHU3alhDSmtXNWdIUDFxMk9neGRSdlhGSHZcL2J5ekJ5ZHMrbzRBZlwvQXFEU25XWFZIN1NMOG9vZVoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 14:16:11 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 13, 2018 1:51 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Tan, Jianfeng > Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_errno values for IPC API >=20 > > > rte_errno values should not be negative. > > > > > > Fixes: bacaa2754017 ("eal: add channel for multi-process communicatio= n") > > > Fixes: 783b6e54971d ("eal: add synchronous multi-process communicatio= n") > > > Cc: jianfeng.tan@intel.com > > > Signed-off-by: Anatoly Burakov > > > > Reviewed-by: Jianfeng Tan > > > > Thanks for fixing this. >=20 > Applied, thanks >=20 > There are a lot of similar issues: >=20 > git grep -l 'rte_errno =3D -E' | sed 's,[^/]*$,,' | sort -u >=20 > drivers/event/opdl/ > drivers/event/sw/ > lib/librte_eventdev/ I just checked the eventdev.h port_link() docs, which indicate negative ret= urn values. Perhaps the header is wrong too - but the PMDs adhere to the library header= in this case. Is there a requirement for rte_errno to be positive? It looks to be declared as per-lcore signed int in rte_errno.h +20 Either-way, if we want to change the PMDs, we should change the Eventdev AP= Is, which means API breakage, and application changes to handle changed return = values. Sound like more work than it is worth it to me?