From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 009C71E20 for ; Tue, 13 Mar 2018 10:25:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 02:25:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="24061633" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga008.fm.intel.com with ESMTP; 13 Mar 2018 02:24:59 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Mar 2018 09:24:58 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.10]) by irsmsx155.ger.corp.intel.com ([169.254.14.21]) with mapi id 14.03.0319.002; Tue, 13 Mar 2018 09:24:58 +0000 From: "Van Haaren, Harry" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Yigit, Ferruh" , Shahaf Shuler , Yongseok Koh Thread-Topic: [dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values Thread-Index: AQHTuixCU8HocglNwECOWCKKJADyNKPN5FFg Date: Tue, 13 Mar 2018 09:24:58 +0000 Message-ID: References: <20180312150523.74621-1-ferruh.yigit@intel.com> <20180312175308.190393-1-ferruh.yigit@intel.com> In-Reply-To: <20180312175308.190393-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ0YmQzNGYtYWRlZi00ZTQ5LWI3NDctYzNmNTU5ZmM5OGYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIxK1c0TlZaa05QbUpOTjhrb3VzYjVvYzhhaUVxWDVVOEFRV3hFRlJ6dmtqUE9zdWVkRTk3dVhjZVpxQ0sydVZaIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 09:25:01 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Monday, March 12, 2018 5:53 PM > To: Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; Yigit, Ferruh ; Shahaf Shuler > ; Yongseok Koh > Subject: [dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values >=20 > Which per port offloads are enabled is not clear. Printing offloads > values at forwarding start. >=20 > CRC strip offload value was printed in more verbose manner, it is > removed since Rx/Tx offload values covers it and printing only CRC one > can cause confusion. >=20 > Hexadecimal offloads values are not very user friendly but preferred to > not create to much noise during forwarding start. Hmmm - I'm thinking is there a better method to reduce verbosity, but keep user friendliness? Can the dynamic logs be used? By default, just print the hex mask, but with --log-level=3D"pmd.net.*.offload_flags" we print the list, itemized? crc strip .......... 1 vlan strip ......... 1 udp checksum ....... 0 I'm not sure what the exact string should be - testpmd specific or DPDK wid= e at the PMD level?