From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
Cc: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Vangati, Narender" <narender.vangati@intel.com>,
"Eads, Gage" <gage.eads@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs
Date: Wed, 9 May 2018 15:19:05 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E135F5B@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1525464964-5342-2-git-send-email-erik.g.carrillo@intel.com>
> -----Original Message-----
> From: Carrillo, Erik G
> Sent: Friday, May 4, 2018 9:16 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: jerin.jacob@caviumnetworks.com; Vangati, Narender
> <narender.vangati@intel.com>; Eads, Gage <gage.eads@intel.com>; dev@dpdk.org
> Subject: [PATCH v1 1/1] service: Add service lcore attr APIs
>
> Add a counter that gets bumped each time the service runner loop goes
> around, and APIs to query and reset the attribute values.
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>From cover letter for this patch:
This patch proposes the addition of an API which allows an application to
query the attributes of a service lcore. It adds one such new attribute,
named "loops", which is a counter that tracks the number of times the service
core has looped in the service runner function (the driver function that
invokes services mapped to a service core). This is useful to applications
that desire a "liveness" check to make sure a service core is not stuck.
When sending a single patch it is not required to send with --cover-letter.
I like the description provided in the cover letter, perhaps merge the
current commit message with the cover-letter paragraph?
For the v2, please include
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2018-05-09 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 20:16 [dpdk-dev] [PATCH v1 0/1] Add service lcore attributes API Erik Gabriel Carrillo
2018-05-04 20:16 ` [dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs Erik Gabriel Carrillo
2018-05-09 15:19 ` Van Haaren, Harry [this message]
2018-05-09 15:22 ` Carrillo, Erik G
2018-05-09 16:22 ` [dpdk-dev] [PATCH v2 " Erik Gabriel Carrillo
2018-07-11 21:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA65E135F5B@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=gage.eads@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narender.vangati@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).