From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 987441B6DB for ; Wed, 9 May 2018 17:19:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2018 08:19:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,382,1520924400"; d="scan'208";a="222907740" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga005.jf.intel.com with ESMTP; 09 May 2018 08:19:07 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 9 May 2018 16:19:06 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.249]) by irsmsx111.ger.corp.intel.com ([169.254.2.47]) with mapi id 14.03.0319.002; Wed, 9 May 2018 16:19:06 +0100 From: "Van Haaren, Harry" To: "Carrillo, Erik G" CC: "jerin.jacob@caviumnetworks.com" , "Vangati, Narender" , "Eads, Gage" , "dev@dpdk.org" Thread-Topic: [PATCH v1 1/1] service: Add service lcore attr APIs Thread-Index: AQHT4+TQdATbKBnmCESpi7Xh2Vza9qQniDDQ Date: Wed, 9 May 2018 15:19:05 +0000 Message-ID: References: <1525464964-5342-1-git-send-email-erik.g.carrillo@intel.com> <1525464964-5342-2-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: <1525464964-5342-2-git-send-email-erik.g.carrillo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGU4Y2RlNTUtZmFiZi00OTc1LWJhOGMtYjczZDg4Zjk1Y2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJpTWRYV1RacGtCNmpOUG1ZRmVXWWxuTGp4aENyTW5nY0pEbE40K2dYT0djbzVRZjhwS3dUUGZpdnVJbXNlbVZzIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 15:19:10 -0000 > -----Original Message----- > From: Carrillo, Erik G > Sent: Friday, May 4, 2018 9:16 PM > To: Van Haaren, Harry > Cc: jerin.jacob@caviumnetworks.com; Vangati, Narender > ; Eads, Gage ; dev@dpdk.= org > Subject: [PATCH v1 1/1] service: Add service lcore attr APIs >=20 > Add a counter that gets bumped each time the service runner loop goes > around, and APIs to query and reset the attribute values. >=20 > Signed-off-by: Erik Gabriel Carrillo >>From cover letter for this patch: This patch proposes the addition of an API which allows an application to query the attributes of a service lcore. It adds one such new attribute, named "loops", which is a counter that tracks the number of times the servi= ce core has looped in the service runner function (the driver function that invokes services mapped to a service core). This is useful to applications that desire a "liveness" check to make sure a service core is not stuck. When sending a single patch it is not required to send with --cover-letter. I like the description provided in the cover letter, perhaps merge the current commit message with the cover-letter paragraph? For the v2, please include Acked-by: Harry van Haaren