From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A046A1E98A for ; Thu, 14 Jun 2018 12:20:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2018 03:20:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,222,1526367600"; d="scan'208";a="64029509" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2018 03:20:10 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.146]) by IRSMSX151.ger.corp.intel.com ([169.254.4.216]) with mapi id 14.03.0319.002; Thu, 14 Jun 2018 11:20:09 +0100 From: "Van Haaren, Harry" To: "Eads, Gage" , "dev@dpdk.org" CC: "jerin.jacob@caviumnetworks.com" , "Richardson, Bruce" , "Rao, Nikhil" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" Thread-Topic: [PATCH 2/2] event/sw: support device stop flush callback Thread-Index: AQHT+OcvB6AYBPxLB02h/VvxHAJ+sqRfn9sQ Date: Thu, 14 Jun 2018 10:20:08 +0000 Message-ID: References: <20180531135557.7544-1-gage.eads@intel.com> <20180531135557.7544-3-gage.eads@intel.com> In-Reply-To: <20180531135557.7544-3-gage.eads@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjRmNWZmZjYtNjhiZS00ZjM3LWFmNjItMDRmM2EyOThiZDAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUHpQY1lNRTRnOHY2NEY5TmlHR2JocFpHbEZVcllXZm5LWGhLanNWMUVyNGNRK0FVc0U5VytjeWVkNk1oYTFkWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 10:20:12 -0000 > From: Eads, Gage > Sent: Thursday, May 31, 2018 2:56 PM > To: dev@dpdk.org > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > ; Richardson, Bruce ; > Rao, Nikhil ; Carrillo, Erik G > ; Gujjar, Abhinandan S > > Subject: [PATCH 2/2] event/sw: support device stop flush callback >=20 > This commit also adds a flush callback test to the sw eventdev's selftest > suite. >=20 > Signed-off-by: Gage Eads One compile warning below, with that fixed; Acked-by: Harry van Haaren > +static void > +sw_drain_queues(struct rte_eventdev *dev) > +{ > + struct sw_evdev *sw =3D sw_pmd_priv(dev); > + int i, j; > + > + for (i =3D 0; i < sw->qid_count; i++) { I'm seeing an int vs unsigned comparison between i and sw->qid_count. > + for (j =3D 0; j < SW_IQS_MAX; j++) > + sw_drain_queue(dev, &sw->qids[i].iq[j]); > + } > +}