From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4428F235 for ; Wed, 25 Jul 2018 14:27:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 05:27:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,401,1526367600"; d="scan'208";a="243187637" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga005.jf.intel.com with ESMTP; 25 Jul 2018 05:27:15 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.110]) by IRSMSX152.ger.corp.intel.com ([169.254.6.61]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 13:27:14 +0100 From: "Van Haaren, Harry" To: "Ananyev, Konstantin" , "Dumitrescu, Cristian" , Mordechay Haimovsky , Thomas Monjalon , "Singh, Jasvinder" CC: "dev@dpdk.org" , "Iremonger, Bernard" , "Pattan, Reshma" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInJOyDQN1nQWxU6EtGfv/1Ph1aSeLF2AgAATHYCAACKJAIAAJ7IAgAENngCAAAjSAIAAIlsAgAAFAwCAAAXygIAAEO1A Date: Wed, 25 Jul 2018 12:27:13 +0000 Message-ID: References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1876510.4y0gDTZx5Q@xps> <1925999.Zqez9Xlb98@xps> <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258DF51D3C1@irsmsx105.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E779722@IRSMSX107.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258DF51D5A2@irsmsx105.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E7797DD@IRSMSX107.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258DF51D5D3@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258DF51D5D3@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2I3YTM0ZjctNjEyMi00ODYzLWI5MGYtNGZmZGEzNjM5YTBmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGIwMVNWVW9SVkQ2cnlaeXoyeHJRNzN3V1U5V3pVb2hkbmEzU0c0N2RVcW9jMnpmSUJxOUdVUzNpSlNobXp6TCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 12:27:20 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 1:18 PM > To: Dumitrescu, Cristian ; Mordechay Haimo= vsky > ; Thomas Monjalon ; Singh, Jasvi= nder > > Cc: dev@dpdk.org; Iremonger, Bernard ; Patta= n, > Reshma ; olivier.matz@6wind.com; Van Haaren, Har= ry > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 >=20 >=20 > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Wednesday, July 25, 2018 12:57 PM > > To: Ananyev, Konstantin ; Mordechay Haimo= vsky > ; Thomas Monjalon > > ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; Pat= tan, > Reshma ; > > olivier.matz@6wind.com; Van Haaren, Harry > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctr= l+d > > > > > > > > > -----Original Message----- > > > From: Ananyev, Konstantin > > > Sent: Wednesday, July 25, 2018 12:39 PM > > > To: Dumitrescu, Cristian ; Mordechay > > > Haimovsky ; Thomas Monjalon > > > ; Singh, Jasvinder > > > Cc: dev@dpdk.org; Iremonger, Bernard ; > > > Pattan, Reshma ; olivier.matz@6wind.com; Van > > > Haaren, Harry > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using c= trl+d > > > > > > > > > > > > > -----Original Message----- > > > > From: Dumitrescu, Cristian > > > > Sent: Wednesday, July 25, 2018 10:36 AM > > > > To: Ananyev, Konstantin ; Mordechay > > > Haimovsky ; Thomas Monjalon > > > > ; Singh, Jasvinder > > > > Cc: dev@dpdk.org; Iremonger, Bernard ; > > > Pattan, Reshma ; > > > > olivier.matz@6wind.com > > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using > ctrl+d > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ananyev, Konstantin > > > > > Sent: Wednesday, July 25, 2018 10:04 AM > > > > > To: Dumitrescu, Cristian ; Mordech= ay > > > > > Haimovsky ; Thomas Monjalon > > > > > ; Singh, Jasvinder > > > > > Cc: dev@dpdk.org; Iremonger, Bernard ; > > > > > Pattan, Reshma ; olivier.matz@6wind.com > > > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit usi= ng > > > ctrl+d > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dumitrescu= , > > > > > Cristian > > > > > > Sent: Tuesday, July 24, 2018 5:59 PM > > > > > > To: Mordechay Haimovsky ; Thomas Monjalon > > > > > ; Singh, Jasvinder > > > > > > > > > > > > Cc: dev@dpdk.org; Iremonger, Bernard > > > ; > > > > > Pattan, Reshma ; > > > > > > olivier.matz@6wind.com > > > > > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit u= sing > > > ctrl+d > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Mordechay Haimovsky [mailto:motih@mellanox.com] > > > > > > > Sent: Tuesday, July 24, 2018 3:37 PM > > > > > > > To: Thomas Monjalon ; Singh, Jasvinder > > > > > > > > > > > > > > Cc: dev@dpdk.org; Iremonger, Bernard > > > ; > > > > > > > Pattan, Reshma ; > > > olivier.matz@6wind.com; > > > > > > > Dumitrescu, Cristian > > > > > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit > using > > > > > ctrl+d > > > > > > > > > > > > > > Even after this fix we still have setups that use netvsc for > example, > > > on > > > > > > > which testpmd exits with rte_panic right after loading it eve= n > > > without > > > > > > > touching the KBD. > > > > > > > > > > > > > > I recommend returning the previous prompt routine in test- > > > > > pmd/cmdline.c > > > > > > > and rework the SOFTNIC section there, preferably moving its p= oll > > > section > > > > > to > > > > > > > use rte_service in a separate file cleaning the CLI files fro= m > PMD- > > > specific > > > > > > > implementation. > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > Sent: Tuesday, July 24, 2018 3:34 PM > > > > > > > > To: Jasvinder Singh > > > > > > > > Cc: dev@dpdk.org; bernard.iremonger@intel.com; > > > > > > > > reshma.pattan@intel.com; Mordechay Haimovsky > > > > > > > ; > > > > > > > > olivier.matz@6wind.com; cristian.dumitrescu@intel.com > > > > > > > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd ex= it > > > using > > > > > ctrl+d > > > > > > > > > > > > > > > > Important note: > > > > > > > > testpmd is currently really broken. > > > > > > > > We cannot have a RC2 until it is fixed. > > > > > > > > > > > > > > > > > > > > > > > > 24/07/2018 13:25, Thomas Monjalon: > > > > > > > > > 23/07/2018 12:44, Jasvinder Singh: > > > > > > > > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmi= ssion > > > > > > > > > > character (EOT) on the empty command line. > > > > > > > > > > > > > > > > > > Please describe what is the issue and what is the cause. > > > > > > > > > > > > > > > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forwa= rd > > > > > mode") > > > > > > > > > > > > > > > > > > > > Reported-by: Mordechay Haimovsky > > > > > > > > > > Signed-off-by: Jasvinder Singh > > > > > > > > > > --- > > > > > > > > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > > > > > > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > > > > > > > > > > > > > > > It is very suspicious to change the cmdline library. > > > > > > > > > If there is a bug in this library, it deserves a separate= fix. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > First, testpmd is not really broken, as only thing that changed= is > the Ctrl > > > + > > > > > D behavior. I agree this is an issue that we need to fix, as > > > > > > it looks that it is breaking some automation scripts for some > people. > > > > > > > > > > > > The change in behavior for Ctrl + D exit is caused by replacing= the > call > > > to > > > > > cmdline_interact() with calling cmdline_poll() in a loop. > > > > > > These two approaches should be identical in behavior, but it lo= oks > like > > > they > > > > > are not due to some issue in the cmdline library. > > > > > > Jasvinder proposed a quick patch, but it looks like something e= lse > needs > > > to > > > > > be fixed in cmdline library in order to bring > > > > > > cmdline_poll() on parity with cmdline_interact(). Any advice fr= om > > > Olivier > > > > > would be very much appreciated! > > > > > > > > > > > > It is really a bad practice to use cmdline_interact() in testpm= d, as > it is a > > > > > blocking call that prohibits doing other things on the same > > > > > > thread that runs the CLI. Sometimes we need to run other things= on > the > > > > > same core, e.g. the slow softnic_manage() function. > > > > > > > > > > Curious why not use a service core for softnic background stuff, = and > leave > > > CLI > > > > > one for CLI? > > > > > Konstantin > > > > > > > > I guess for a test application you can do anything you want, but in= real > life > > > CPU cores are really expensive and dedicating a CPU core > > > > just for CLI is a colossal waste. > > > > > > Ok, but let's application developer to decide how to use (waste) the = cores > he > > > owns :) > > > What I am saying: there is a special thing (developed by Harry) servi= ce > cores. > > > As I understand why of it's the purpose - allow PMD(s) to allocate CP= U > > > resources for > > > there background tasks in a unified and transparent way. > > > From the description above - that seems to fit your needs (softnic > > > background processing), no? > > > Konstantin > > > > > > > Then why not put the testpmd CLI itself on a service core? Are you > volunteering for a patch on this? :) >=20 > It was not me who broke testpmd at first place. > I'd better live without softnic support in testpmd :) > Though I still don't understand why do you feel that service cores are no= t > good enough for you? > From my understanding they were introduced for similar purposes > (Harry please feel free to correct me here). > So if you think they not fit for your case - > at least would be good to understand why. > Konstantin Service-cores is a mechanism to abstract SW fallback CPU core requirements; Eg: A nic provides RSS, 0 cores required A NIC does not provide RSS, use 1 service core to provide that RSS func= tion Result: the application can rely on RSS, as we have a transparent fallback: no application controlled lcore is performing any different than before wit= h HW provided functionality Service cores is not intended to be used for "background" tasks, as the service-core consumes an Lcore and polls 100% of the time, regardless of what services it is performing. If there are multiple things that we can run on service-cores, that would m= ake sense. Eg: timer_manage(), CLI (non-blocking..), SoftNIC background tasks..= . This design makes sense as the application can also register its own "backg= round" services, and run them all on a single service-core. > > > > > > > > > > > > We did use the non-blocking cmdline_poll() function instead of the > > > blocking cmdline_interact() in the past without any issues. The > > > > issues reported by Moti come as a surprise. It is probably good to = see > what > > > this is about and see if we can quickly fix the issue in > > > > cmdline library. Otherwise, we can revert the usage of cmdline_poll= () > with > > > cmdline_interact(). > > > > > > > > > > > > > > > > > > > > > > > > > Worst case scenario: We can revert the cmdline_poll() back to > > > > > cmdline_interact(), this is a small change, but not the proper wa= y of > > > > > > doing things, as this is simply hiding the issue in cmdline lib= rary. > It > > > would > > > > > also prevent us from testing some Soft NIC functionality.